* Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)
[not found] ` <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org>
@ 2024-10-30 14:17 ` Andrea Corallo
2024-10-31 5:37 ` Yuan Fu
0 siblings, 1 reply; 4+ messages in thread
From: Andrea Corallo @ 2024-10-30 14:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Yuan Fu
Yuan Fu <casouri@gmail.com> writes:
> branch: master
> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
> Fix c-ts-common-comment-indent-new-line (bug#73900)
>
> * lisp/progmodes/c-ts-common.el:
> (c-ts-common-comment-indent-new-line): Delete trailing
> whitespace before inserting newline. The insert-line-break
> function is the same as in c-indent-new-comment-line.
> ---
> lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------------
> 1 file changed, 55 insertions(+), 49 deletions(-)
Hi Yuan,
I believe this is introducing the following building master:
progmodes/c-ts-common.el:339:27: Warning: reference to free variable ‘allow-auto-fill’
IIUC some code was imported in 'c-ts-common-comment-indent-new-line'
from 'c-indent-new-comment-line' but in the latter the interface
includes the 'allow-auto-fill' optional parameter.
Would you mind having a look?
Please always check that the build is clean before installing a change.
Thanks
Andrea
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)
2024-10-30 14:17 ` master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900) Andrea Corallo
@ 2024-10-31 5:37 ` Yuan Fu
0 siblings, 0 replies; 4+ messages in thread
From: Yuan Fu @ 2024-10-31 5:37 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
> On Oct 30, 2024, at 7:17 AM, Andrea Corallo <acorallo@gnu.org> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> branch: master
>> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>>
>> Fix c-ts-common-comment-indent-new-line (bug#73900)
>>
>> * lisp/progmodes/c-ts-common.el:
>> (c-ts-common-comment-indent-new-line): Delete trailing
>> whitespace before inserting newline. The insert-line-break
>> function is the same as in c-indent-new-comment-line.
>> ---
>> lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------------
>> 1 file changed, 55 insertions(+), 49 deletions(-)
>
> Hi Yuan,
>
> I believe this is introducing the following building master:
>
> progmodes/c-ts-common.el:339:27: Warning: reference to free variable ‘allow-auto-fill’
>
> IIUC some code was imported in 'c-ts-common-comment-indent-new-line'
> from 'c-indent-new-comment-line' but in the latter the interface
> includes the 'allow-auto-fill' optional parameter.
>
> Would you mind having a look?
>
> Please always check that the build is clean before installing a change.
>
> Thanks
>
> Andrea
Yes, thanks for the notice. And apologies :( It should be fixed now.
Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)
@ 2024-10-29 12:32 Eli Zaretskii
2024-10-31 5:37 ` Yuan Fu
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2024-10-29 12:32 UTC (permalink / raw)
To: Yuan Fu; +Cc: emacs-devel
> branch: master
> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
> Fix c-ts-common-comment-indent-new-line (bug#73900)
>
> * lisp/progmodes/c-ts-common.el:
> (c-ts-common-comment-indent-new-line): Delete trailing
> whitespace before inserting newline. The insert-line-break
> function is the same as in c-indent-new-comment-line.
This triggers the following byte-compilation warning:
In c-ts-common-comment-indent-new-line:
progmodes/c-ts-common.el:339:27: Warning: reference to free variable `allow-auto-fill'
I'm guessing that in c-ts-mode case allow-auto-fill is always nil.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)
2024-10-29 12:32 Eli Zaretskii
@ 2024-10-31 5:37 ` Yuan Fu
0 siblings, 0 replies; 4+ messages in thread
From: Yuan Fu @ 2024-10-31 5:37 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> On Oct 29, 2024, at 5:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> branch: master
>> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>>
>> Fix c-ts-common-comment-indent-new-line (bug#73900)
>>
>> * lisp/progmodes/c-ts-common.el:
>> (c-ts-common-comment-indent-new-line): Delete trailing
>> whitespace before inserting newline. The insert-line-break
>> function is the same as in c-indent-new-comment-line.
>
> This triggers the following byte-compilation warning:
>
> In c-ts-common-comment-indent-new-line:
> progmodes/c-ts-common.el:339:27: Warning: reference to free variable `allow-auto-fill'
>
> I'm guessing that in c-ts-mode case allow-auto-fill is always nil.
Thank Eli, I’ve fixed it now. Sorry for the hiccup.
Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-31 5:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173018710062.2953743.6862996178790876925@vcs3.savannah.gnu.org>
[not found] ` <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org>
2024-10-30 14:17 ` master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900) Andrea Corallo
2024-10-31 5:37 ` Yuan Fu
2024-10-29 12:32 Eli Zaretskii
2024-10-31 5:37 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).