From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900) Date: Wed, 30 Oct 2024 10:17:08 -0400 Message-ID: References: <173018710062.2953743.6862996178790876925@vcs3.savannah.gnu.org> <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5600"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 30 15:18:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t69WR-0001Jg-Vd for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Oct 2024 15:18:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t69Vp-0007oZ-E5; Wed, 30 Oct 2024 10:17:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t69VZ-0007iM-9d for emacs-devel@gnu.org; Wed, 30 Oct 2024 10:17:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t69VY-0001Vx-Tq; Wed, 30 Oct 2024 10:17:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0JKJO2x2SzgV8G4h9s+P+CJnK+VOzbtT0djmdpt7q9c=; b=mK90ebv+QW/5lvH01aFS pMe2QmXkBcfIgqkwdZJW7pxLZEJiVlTfmCwJctiw9PIoKcYobVDSoXo1qE31vCsLkd/Mx3PMJyGk3 cd+MNXWOjLt/Rt+CFk3un/YM5peeeT6fycDlV6M+m4v69bqVkOPGQbtvx39ui0h0hqzWGunBUcE8z fqdHd7HhlUlYZrTtQhSRHd/vi22sxr7lIJBaVDrqA7IIXfVhNxS4Ll0Hl4ZrP9hRMaLuEOWzsPG4R D2NTbdrFLnOP6VxLYgo7+yhMnf/TV8elQHB8wv0IxIAFitpyerPDSV2LpIoA2cp8IeUNBElM04eE5 7Wz/3dU630ag3A==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1t69VV-0004EV-FT; Wed, 30 Oct 2024 10:17:12 -0400 In-Reply-To: <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org> (Yuan Fu's message of "Tue, 29 Oct 2024 03:31:40 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324940 Archived-At: Yuan Fu writes: > branch: master > commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96 > Author: Yuan Fu > Commit: Yuan Fu > > Fix c-ts-common-comment-indent-new-line (bug#73900) >=20=20=20=20=20 > * lisp/progmodes/c-ts-common.el: > (c-ts-common-comment-indent-new-line): Delete trailing > whitespace before inserting newline. The insert-line-break > function is the same as in c-indent-new-comment-line. > --- > lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------= ------ > 1 file changed, 55 insertions(+), 49 deletions(-) Hi Yuan, I believe this is introducing the following building master: progmodes/c-ts-common.el:339:27: Warning: reference to free variable =E2=80= =98allow-auto-fill=E2=80=99 IIUC some code was imported in 'c-ts-common-comment-indent-new-line' from 'c-indent-new-comment-line' but in the latter the interface includes the 'allow-auto-fill' optional parameter. Would you mind having a look? Please always check that the build is clean before installing a change. Thanks Andrea