From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Mon, 04 Mar 2024 04:46:29 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 04 10:47:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rh4v1-0000LI-5y for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Mar 2024 10:47:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh4u7-0007hc-Hu; Mon, 04 Mar 2024 04:46:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh4u0-0007eO-Jy for emacs-devel@gnu.org; Mon, 04 Mar 2024 04:46:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh4tz-0000nr-PE; Mon, 04 Mar 2024 04:46:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=yikAZ0DUR+bwkWz53Fe3Oa+4bHw1LjXG7JaPhAZr88E=; b=R/k96DJuT3lSZpCuKbaR 7x1tFCLsAH9aKwveMa1IB5jWkG0320c9etaDJo9p8DpliLjr1T+0kjKCGDW2aL+9WTwJXfgmVHZFV zMiK4vO7/NC2SnILiKW+uLnobmRSPwI/qRFSGCYI+IFF4vZoA1cHh8L+pErl7TxoYOwWt1NOCdNt5 QKzzDIBe8stkiUWWhZLyaSWbCA/3GlkJ/PIrqg7vHK7XbYLh8So/oANT9j4FDXPLJp5nC++Q0njG8 D+IqSdZpcDfdtxUrCrJ9obORZ0KB5ZUOJzX2aCVCUfOe2lB8p+5Qlne7uTkfqGfTxk7TU4JkFKxUs DytlrkClwEwl/Q==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rh4tx-0002Xh-CE; Mon, 04 Mar 2024 04:46:30 -0500 In-Reply-To: (Andrea Corallo's message of "Mon, 04 Mar 2024 04:36:45 -0500") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316785 Archived-At: Andrea Corallo writes: > Stefan Monnier via Mailing list for Emacs changes > writes: > >> branch: master >> commit 1d9d07fb00e6b62641c07af68f986e700b5f6cee >> Author: Stefan Monnier >> Commit: Stefan Monnier >> >> (cl--typeof-types): Rework to fix some regressions >>=20=20=20=20=20 >> Initialize the variables directly in their declaration, so >> there no time where they exist but aren't yet initialized. >> This also allows us to mark `cl--typeof-types` as a `defconst` again. >>=20=20=20=20=20 >> More importantly, specify the DAG by direct supertypes rather >> than direct subtypes. This is slightly less compact, but it's >> necessary to let us specify the *order* of the supertypes, >> which is necessary for example to preserve the desired ordering >> of methods when several methods can be applied. > > Hi Stefan, > > I'm not sure I understand. Is some code relying on the "order" of the > supertypes? Are these the regression you are mentioning? > > Must say I'm surprised supertypes can have an "order" in first place. Also, this commit makes etc/syncdoc-type-hierarchy.el not functional and our doc out of sync (it removes the comment asking to run etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as well =F0=9F=99=81). Andrea