From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Wed, 18 Dec 2024 17:27:04 -0500 Message-ID: References: <86seqmm9dq.fsf@gnu.org> <87frml9cy4.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 23:27:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tO2WN-000978-Gu for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 23:27:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tO2Vb-0002DD-Da; Wed, 18 Dec 2024 17:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tO2VZ-0002D0-U1 for emacs-devel@gnu.org; Wed, 18 Dec 2024 17:27:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tO2VY-0000dz-PJ; Wed, 18 Dec 2024 17:27:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cOIxXtqmJPyqAnoqbAHvQB/6K1/zocV1c5okNNSxWKw=; b=n2chhAqF5y/lbGWxi5Pr 8+5gFIG4IOxykX1Y1p7M3eU63885+OgCag2L8rbnLSxPJb4AdMc6U2FeNnLYQXtisv6Zea4sf6KfO Gde1AsrbLIrtXBmgWfpbrElR/PPhjVEl1emnDVKzFy74t09xT4B7CeVjf8CJ6sWyUzrz1/eLfcafS 3IXNTX4C2Bc1ZuftTLqy9ojqYWckF4+XUeNk7Lf8jRaqEtP0GCgAgLQpeo9tFHRvmGNpSSKrMvuhR hVkAPcUGa3fQOxkxZMHrdZ2qPGWyeX+I2/zG7J/cmMqx79Vx7+xzafKOndD2ndGJ1eit5A0BYA4rG ZmFGJWobe+Gn9w==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1tO2VU-0004g8-Iu; Wed, 18 Dec 2024 17:27:04 -0500 In-Reply-To: <87frml9cy4.fsf@protonmail.com> (Pip Cet's message of "Wed, 18 Dec 2024 16:25:08 +0000") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326689 Archived-At: Pip Cet writes: > Pip Cet writes: >> IOW, the old code happened not to run into this problem because >> lambda-fixup was pure, and we never applied the sanity checks to the >> pure section. > > Just to be clear: the code on master is fine. I misunderstood it when > modifying it for purespace removal, resulting in my bug which Gerd > discovered and fixed. The code on no-purespace is also fine now, but > it's Andrea's call whether he wants some of the checking code restored, > and how. > >> My suggestion is to fix the "sanity check" on the master branch, change >> it to apply to pure relocs there, and restore the fixed check on >> scratch/no-purespace afterwards. > > Please ignore that. My suggestion is to EXTEND the sanity check on the > master branch to cover pure and impure relocs, and restore the EXTENDED > check before merging scratch/no-purespace. > > There is no bug to fix on master. Right your analysis is correct, the new code in the branch just made the symbol 'fixup-lambda' not compilable. I restored the check and applied a variant of your fix with a comment around. scratch/no-purespace work for me now. On master I don't think I see what we should do and the motivation for.