From: Andrea Corallo <acorallo@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Wed, 11 Dec 2024 18:38:32 -0500 [thread overview]
Message-ID: <yp1ttb9eqo7.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <791c31a1-84ab-4cab-921b-cc8977e980d9@gutov.dev> (Dmitry Gutov's message of "Sun, 8 Dec 2024 18:01:39 +0200")
Dmitry Gutov <dmitry@gutov.dev> writes:
> On 04/12/2024 20:19, Yuan Fu wrote:
>> When Emacs is built without tree-sitter, none of the treesit.c functions are available (except for treesit-ready-p)
>
> Have we considered having all of those functions defined but doing
> nothing in that case? Alias them to 'ignore' or something that raises
> an error.
>
> I think then we won't have to maintain these 'declare-function' lists
> in every package that depends on treesit.c.
The suggestion of having the C functions defined to nops when
HAVE_TREE_SITTER is not defined is cleaner in principle, but I think
there are two downsides:
- We don't tipically do it this way, so it would be an exception
- Also we should do it for all the functions in treesit.c, otherwise we
don't solve the original problem of introducing warnings by mistake on
non treesit builds.
Andrea
next prev parent reply other threads:[~2024-12-11 23:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03 8:30 ` Andrea Corallo
2024-12-04 18:21 ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19 ` Yuan Fu
2024-12-04 18:57 ` Eli Zaretskii
2024-12-05 6:25 ` Yuan Fu
2024-12-05 7:07 ` Eli Zaretskii
2024-12-07 1:12 ` Yuan Fu
2024-12-07 7:51 ` Eli Zaretskii
2024-12-07 13:47 ` Stefan Monnier
2024-12-08 6:39 ` Yuan Fu
2024-12-08 7:20 ` Eli Zaretskii
2024-12-11 23:28 ` Andrea Corallo
2024-12-08 15:27 ` Stefan Monnier
2024-12-09 1:37 ` Yuan Fu
2024-12-09 2:40 ` Stefan Monnier
2024-12-11 1:57 ` Dmitry Gutov
2024-12-08 16:01 ` Dmitry Gutov
2024-12-11 23:38 ` Andrea Corallo [this message]
2024-12-12 0:23 ` Dmitry Gutov
2024-12-12 6:05 ` Yuan Fu
2024-12-12 6:43 ` Eli Zaretskii
2024-12-12 6:19 ` Eli Zaretskii
2024-12-12 6:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1ttb9eqo7.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).