From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 10:12:54 -0400 Message-ID: References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14233"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 16:13:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRBbL-0003WC-1I for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 16:13:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRBaZ-0005uY-Rd; Tue, 09 Jul 2024 10:13:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBaY-0005q5-Sf for emacs-devel@gnu.org; Tue, 09 Jul 2024 10:13:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBaY-0008Nq-JO; Tue, 09 Jul 2024 10:13:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=5n60uXw9Iaq69deNaRYUNRqjgmdN83u2Mz4A83coLQo=; b=QrqgPS6SBIpfdb2xKpri YnQehIxw68EKMBfLsBQmCCbrGeH+v5zjoK0IdHhx/Tvo96h3Znm7iOFXFcpUs6LtgwaKjjcV09asS xiQHvdtgzs3O3b3Dw3HqnlLIkKsTPEApz5I4dqcfsHGLR5B3ME9Jb55lNfUk+p8IH4zvQvvfw/2Cz c7+IySYX+ZnQStH5fF9I1FiMcAgl7IFcvL6reiUb3Pevk0C80bu+ItSjuliY/CuzDfTGaJVErqHRn 6yxqLp9Z0ZzmQhVpMNV4e3p8j/st1hOfqC/RweJazNEhwNh8kNxWp465ysoarpGMkD0uogLEX7nrn xTbdYmEyE3K7OQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sRBaT-0000KH-3p; Tue, 09 Jul 2024 10:13:02 -0400 In-Reply-To: (Pip Cet's message of "Tue, 09 Jul 2024 13:58:06 +0000") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321565 Archived-At: Pip Cet writes: > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo wrote: >> Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes: >> >> > branch: scratch/igc >> > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 >> > Author: Pip Cet pipcet@protonmail.com >> > Commit: Pip Cet pipcet@protonmail.com >> > >> > Fix GTK-related MPS crashes >> > >> > * src/gtkutil.c (free_glib_user_data): New function. >> > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. >> > (qttip_cb, xg_create_frame_widgets) >> > (xg_create_frame_outer_widgets, create_dialog) >> > (make_cl_data, unref_cl_data, xg_mark_data) >> > (menuitem_highlight_callback, xg_create_one_menuitem) >> > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) >> > (draw_page, xg_print_frames_dialog, xg_create_toolbar) >> > (xg_im_context_commit, xg_widget_style_updated) >> > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'. >> > (xg_initialize): Remove linked list if HAVE_MPS. >> > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper >> > functions. >> > * src/xmenu.c (menubar_selection_callback) >> > (popup_selection_callback): Adjust to use `get_glib_user_data'. >> >> Hello, >> >> as on my system gsignal.h does not define G_CONNECT_DEFAULT but only >> G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the >> following on my system: > > Thank you! Can you let me know which gtk/glib version that is? I'd like to check the source code to make sure we can pass the right flag instead. > > I think we're okay just passing 0 instead. > > Pip Should be GTK 3.24.33 and glib 2.0. Thanks Andrea