From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Improving EQ Date: Thu, 12 Dec 2024 05:40:48 -0500 Message-ID: References: <87h679kftn.fsf@protonmail.com> <86frmt1k6w.fsf@gnu.org> <871pydjo23.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Pip Cet , Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Paul Eggert To: Pip Cet via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 12 11:42:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLgdy-0007lF-8D for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Dec 2024 11:42:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLgd7-0005GH-Qq; Thu, 12 Dec 2024 05:41:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLgd3-0005FF-0N for emacs-devel@gnu.org; Thu, 12 Dec 2024 05:41:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLgd0-000211-H2; Thu, 12 Dec 2024 05:41:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=m75UptsMYKYDA1Gh39XGdmDQUo6sDAFFpN+n+XPUD74=; b=joMjSBxTrMN1abC89Q4y +bKkCgGL1V+qqluZkqCS/8bFJ2i8/lyOSYsKk6gHtrHoeS43fDoGp16KqgKA2/m8/Az6x4aMvxv9Z wIN1KUnmhR6R6inLLftvdA1HDoetSTVNb7dXn0Zy7uBmWP0fGbJeOW6ofCbrPwkoqcHJ0ErrMc0vV rXfPTdDKZDru3k+tQh6HzOc7UjNxdhojhu8JHM9uPs18TYhdBxTSJwPqmptw36Y5gJFFc15ldRC6+ nB0N6u+i+TSjoEfHMtytEWNl6qMx10BXncTwpfJgtCsiEgn6m6RH/yffVDI8CRTn1WK7aTtF7iuUF 0QRzYg/V4DZj7A==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1tLgci-0003HQ-Ex; Thu, 12 Dec 2024 05:40:58 -0500 In-Reply-To: <871pydjo23.fsf@protonmail.com> (Pip Cet via's message of "Thu, 12 Dec 2024 08:36:50 +0000") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326420 Archived-At: Pip Cet via "Emacs development discussions." writes: > "Eli Zaretskii" writes: > >>> Date: Wed, 11 Dec 2024 22:37:04 +0000 >>> From: Pip Cet via "Emacs development discussions." >>> >>> What's missing here is a benchmark, but unless there's a really nasty >>> surprise when that happens, I'm quite confident that we can improve the >>> code here. >> >> The usual easy benchmark is to byte-compile all the *.el files in the >> source tree. That is, remove all the *.elc files, then say "make" and >> time that. > > Considering the point of the optimization was to make compilation (when > symbols_with_pos_enabled is true) slower, but speed up non-compilation > use cases, I think that may be the opposite of what we want :-) Glad you finally agree on the goal of the optimization. > Furthermore, the master branch doesn't currently build after deleting > all the *.elc files, because recompilation exceeds max-lisp-eval-depth > in that scenario (together with the known purespace issue, this pretty > much means "make bootstrap" is the only way I can rebuild an emacs tree > right now. It'd be great if Someone could look into this, but I've > failed to understand the native-compilation code (and been told off for > trying to) too often for that Someone to be me. Plus, of course, I fully > understand that native compilation currently has wrong code generation > bugs which obviously have to take priority over build issues...) > >> There was also some Emacs benchmark suite that someone posted, but I >> cannot find it now, maybe someone else will. > > https://elpa.gnu.org/packages/elisp-benchmarks.html ? It'd be great if > we could agree on a benchmark, and even better if there were a way to > reliably run it from emacs -Q :-) What is not reliable in the elisp-benchmarks invocation suggested in the instructions in it? > In fact, I would suggest to move a reduced benchmark suite to the emacs > repo itself, and run it using "make benchmark". That would be nice.