From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: question regarding my emacs package Date: Mon, 12 Jun 2023 12:40:55 -0400 Message-ID: References: <6cG8Tc55Zz8xk6rE6mJLfDxckAINPcYqp781yltsndzqq5146yw76EZ_2CoUtQT4P2j2afSx5VRD5G1-9qzFHWAW3LxYWwmxh87lvB2MgNE=@rj95.be> <873533mfq3.fsf@posteo.net> <87y1kvkv2f.fsf@posteo.net> <2pOYRsmOk_f2sx48BICCjf9r3Z5OviLDonOFi4dhWoSpd_dAWOXFSA3jO2YeyJ5FBf-Sydd0ZTzTOsAlIg8tc_eBqM9nzq2PW4q4usn4Nuo=@rj95.be> <87ilbzkq9y.fsf@posteo.net> <877csetnwy.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="693"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Madhu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 18:41:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8kbY-000Abc-SG for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 18:41:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8kbA-0002fG-SW; Mon, 12 Jun 2023 12:40:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kbA-0002f7-8k for emacs-devel@gnu.org; Mon, 12 Jun 2023 12:40:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kb9-0008Nj-HE; Mon, 12 Jun 2023 12:40:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=gdjRmM2oTDRLlKsibmAD6azHBYq9y7FfvtAId/68hgs=; b=qlb7bNuCxCwHLJi5I5Gv 7WbcgR9f6y63FXalMhDwmYlJNDOe8QbIIAapXCn1XnsbPnQQmvysytiT44uaUt35D2vHOTr2AkJ2y Qx1vd8ntkIp6xGxsLVUgx8kjHJHgapdrKzwI8n0ILFyz2AFcDIlDNnA1/6yLPE2kjEuZFUdDPlxoE BnTrcYCMxp/9VLoELMF1+Dp1r6JAbC/FShHLwcbQTUWLcq8PMLAL6perRGOQKCyYxIeMlGc+uN9v9 Xbo3fHyPgeoZ2GZwWk+l7bI5qEWttAIp3b1ocbgZ6ifiZoKGpY74M1qxPr6oUsYg6+YKLUF1DJSWe bXZqpWVd3oXcXQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1q8kb9-0002PU-At; Mon, 12 Jun 2023 12:40:55 -0400 In-Reply-To: (Madhu's message of "Mon, 12 Jun 2023 18:22:25 +0530") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306755 Archived-At: Madhu writes: > * Madhu : > Wrote on Sun, 11 Jun 2023 17:11:21 +0530: > >> [Question about cl-defstruct] >> >> >> I tried loading the file from github on emacs master and it fails when >> trying to compile >> >> ``` >> (defun breadcrumbs--drop () >> "Track the buffer position as a `breadcrumbs--breadcrumb'. >> >> If this has already been tracked, move an existing one in `breadcrumbs-ring' to head." >> (let* ((breadcrumb (make-breadcrumbs--breadcrumb)) >> (index (ring-member breadcrumbs-ring breadcrumb))) >> ``` >> >> >> with >> ``` >> Debugger entered--Lisp error: (wrong-type-argument stringp (buffer-file-name)) >> make-breadcrumbs--breadcrumb--cmacro((make-breadcrumbs--breadcrumb)) >> apply(make-breadcrumbs--breadcrumb--cmacro (make-breadcrumbs--breadcrumb) nil) >> macroexp--compiler-macro(make-breadcrumbs--breadcrumb--cmacro (make-breadcrumbs--breadcrumb)) >> ``` >> >> The cl-defstruct slot has an initform "(buffer-file-name)" which seems >> legit since it takes an optional argument. >> >> However when I change the form to (buffer-file-name nil) as below, it >> loads >> >> ``` >> (cl-defstruct breadcrumbs--breadcrumb >> (buffer-file-name >> (buffer-file-name nil) >> :documentation "The file backing the breadcrumb.") >> ``` > > > So with my emacs-30 nativecomp this just doesnt work. the > buffer-file-name slot of the cl-defstruct has to be changed to > buffer-file-name-1 (and the corresponding accessors to > breadcrumbs--breadcrumb-buffer-file-name-1) throughout the file. Does it works on the same Emacs codebase without native compilation? Thanks Andrea