From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 10a7615b5d4: Separate filename-deletion mechanism from policy. Date: Mon, 07 Aug 2023 11:21:39 -0400 Message-ID: References: <169132873104.29568.5167661370136073295@vcs2.savannah.gnu.org> <20230806133211.6301AC038BE@vcs2.savannah.gnu.org> <87jzu847hq.fsf@yahoo.com> <83jzu8p8dh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6319"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Po Lu , emacs-devel@gnu.org, esr@thyrsus.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 07 17:22:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qT240-0001NB-03 for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Aug 2023 17:22:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qT23H-00028N-Ob; Mon, 07 Aug 2023 11:21:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT23B-00027Z-U7 for emacs-devel@gnu.org; Mon, 07 Aug 2023 11:21:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT23A-0003FF-Ko; Mon, 07 Aug 2023 11:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ucFLAqKFHPqKDtfjDq+Ld4OmDGNV4cAVeAwNkpvx9uw=; b=aK3VWC3iA6VT8ZXaGDKV AtDgNucTWsCRpxVxpmpYMpfK+583Bvktkqicv9jWAO1X4N+ZpAEmmaxn5HgBKcLlxMpHPatyQbnCd z0/xg2bfI/4u6KYH31uJodEHFXFxU379EQM1wUfOzZqYOJAEJlOCfQVLAm7suZ3OBcdKWwV8vS+gh YrKEwP6PRUpFjJ71i0uEB78WLxApXtNdRz3cBNfFpO8iF0+iif4YsfrIt9pHEzgvDhXNYSSMIeKCF SzFVHpK9ZyKcLezXXffD+RpKlOa5+QYKhl5ttKL7LRAwwmD82X775CVt7S6t+DXLEu76AJQFD4bqs gBueQh+vWXCB+g==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qT239-00043m-Bu; Mon, 07 Aug 2023 11:21:39 -0400 In-Reply-To: <83jzu8p8dh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Aug 2023 17:12:42 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308415 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: "Eric S. Raymond" >> Date: Sun, 06 Aug 2023 21:37:21 +0800 >> >> "Eric S. Raymond" writes: >> >> > This is a pure refactoring step, delete-file's behavior is >> > unchanged. But the C core is a little simpler now. >> > --- >> > lisp/files.el | 20 ++++++++++++++++++++ >> > src/fileio.c | 40 +++++++++------------------------------- >> > 2 files changed, 29 insertions(+), 31 deletions(-) >> > >> > diff --git a/lisp/files.el b/lisp/files.el >> > index f8867432000..84a8c308b09 100644 >> > --- a/lisp/files.el >> > +++ b/lisp/files.el >> > @@ -6352,6 +6352,26 @@ non-nil and if FN fails due to a missing file or directory." >> > (apply fn args) >> > (file-missing (or no-such (signal (car err) (cdr err)))))) >> > >> > +(defun delete-file (filename &optional trash) >> > + "Delete file named FILENAME. If it is a symlink, remove the symlink. >> > +If file has multiple names, it continues to exist with the other names.q >> ^ >> Typo alert! >> >> Thanks. While I'm not enthusiastic about moving functions from C to >> Lisp, others seem to appreciate the gesture, so I won't mention this >> subject now. > > This kind of changes should have been discussed before it was > installed. There are several issues I can see here: > > . delete-file-internal must call expand-file-name on its argument, > as all primitives that interface to the filesystem must; I fixed > that; > . Emacs will now be unable to call delete-file or rename-file during > loadup, until files.el is loaded -- not sure if this is a problem, > but I guess we will see; > . the changeset failed to adjust internal_delete_file, which still > called Fdelete_file; I fixed that (I hope, see below) > > Andrea, please take a look at the last bullet above: I made > internal_delete_file call Fdelete_file_internal, which means it no > longer supports remote files. If that is a problem, we should call > Qdelete_file there, but then I wonder whether calling Lisp at that > place, even though delete-file is preloaded, can cause any trouble? I think calling Qdelete_file *should* work as we guard against circular dependency compilations commanded by the native compiler, but it's impossible to be sure of that without testing the patch. Andrea