From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Andrea Corallo <acorallo@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand
Date: Tue, 03 Dec 2024 04:55:03 -0500
Message-ID: <yp1mshdf5vs.fsf@fencepost.gnu.org>
References: <173314163483.652988.2881826266893472321@vcs3.savannah.gnu.org>
 <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org>
 <yp18qsxhl0c.fsf@fencepost.gnu.org> <87plm9ybmc.fsf@gmx.net>
 <yp1v7w1fajh.fsf@fencepost.gnu.org> <87wmghcdf5.fsf@gmx.net>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="1309"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
Cc: Michael Albinus <michael.albinus@gmx.de>,  emacs-devel@gnu.org
To: Stephen Berman <stephen.berman@gmx.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 10:55:50 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1tIPdG-0000Bp-F9
	for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 10:55:50 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1tIPcX-0005Zl-Vv; Tue, 03 Dec 2024 04:55:06 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <acorallo@gnu.org>) id 1tIPcW-0005ZJ-4h
 for emacs-devel@gnu.org; Tue, 03 Dec 2024 04:55:04 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <acorallo@gnu.org>)
 id 1tIPcV-0006b3-Ko; Tue, 03 Dec 2024 04:55:03 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=7WZFBgrAOxiv6BXvoXPGC3nUBmMMrdXWnxOQP9a6QK4=; b=i3r2WHLUZuz1dujYQW3N
 D0ezrXQV5oZ+dxz/fFqJeXHL02F1lAF0gm8JBEsnLnhMZwAno2q7/R+EqXW4VMrDAs/Oq2f+u3k2E
 3yv8t+UdcgPfPt3E9msD3xzf3SHVNh2gmQHaIzPpQWTAHBxUw5haCPyIFyr2+OamfknLSh5ARxUak
 D9yNGRtBwJZt9iufxcrrqus+I6OE84GhglP48mic6rb0IXK7KPiekvbBfijjT71311pneXTobpfkX
 fLZgzKddf8x8tZWWebEl44gAePmIbz2imv7JmDc6PtgHY5sQ41LIhoRqzppF+c30MtQSS0csNcRrL
 d1v1b3AKInU4MQ==;
Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1)
 (envelope-from <acorallo@gnu.org>)
 id 1tIPcV-0000mj-5T; Tue, 03 Dec 2024 04:55:03 -0500
In-Reply-To: <87wmghcdf5.fsf@gmx.net> (Stephen Berman's message of "Tue, 03
 Dec 2024 10:40:30 +0100")
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:325979
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/325979>

Stephen Berman <stephen.berman@gmx.net> writes:

> On Tue, 03 Dec 2024 03:14:26 -0500 Andrea Corallo <acorallo@gnu.org> wrote:
>
>> Stephen Berman <stephen.berman@gmx.net> writes:
>>
>>> On Mon, 02 Dec 2024 15:45:23 -0500 Andrea Corallo <acorallo@gnu.org> wrote:
>>>
>>>> Stephen Berman via Mailing list for Emacs changes <emacs-diffs@gnu.org>
>>>> writes:
>>>>
>>>>> branch: emacs-30
>>>>> commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d
>>>>> Author: Stephen Berman <stephen.berman@gmx.net>
>>>>> Commit: Stephen Berman <stephen.berman@gmx.net>
>>>>>
>>>>>     Fix latest test for dabbrev-expand
>>>>>
>>>>>     * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer):
>>>>>     Fix typo in a 'should' test, use part of return value of 'should-error'
>>>>>     test, and remove mistaken and unfounded FIXME comment.
>>>>
>>>> Hello Stephen,
>>>>
>>>> this commit is introducing in my test-bed the following three failures
>>>> in emacs-30: dabbrev-expand-test-other-buffer-4,
>>>> dabbrev-expand-test-other-buffer-3, dabbrev-expand-after-killing-buffer.
>>>> Could you please have a look?
>>>>
>>>>   Andrea
>>>
>>> How does your testbed run the tests?  When I invoke `emacs-30 -batch -l
>>> ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el -f
>>> ert-run-tests-batch-and-exit' from the shell, all tests pass.  Likewise,
> [...]
>> my testbench is running "make check -j24" on a fresh checkout on
> [...]
>
> On Tue, 03 Dec 2024 09:19:46 +0100 Michael Albinus <michael.albinus@gmx.de> wrote:
>
> [...]
>> dabbrev-tests.el is broken in the emacs-30 branch. Running 'make -C test
>> dabbrev-tests.log' yields the appended log file.
>
> It seems that substitute-command-keys applies to user-error messages in
> ert batch runs but not when executing `make check'.  I missed the latter
> because when I committed that patch, the emacs-30 build was broken due
> to the librsvg version issue, so I couldn't run `make check'.  But since
> `make check' had succeeded with my previous commit, I wrongly assumed it
> would also succeed this change; I should have waited.  I've now pushed a
> workaround (commit 7b8d12e95de to emacs-30) with which both batch runs
> and `make check' succeed for me.  Hopefully they do for everyone else
> too!

The build looks clean here thanks.

  Andrea