From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Mon, 04 Mar 2024 11:19:49 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 04 17:20:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhB3I-0009NP-1J for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Mar 2024 17:20:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhB2f-0000UL-GT; Mon, 04 Mar 2024 11:19:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhB2d-0000TW-1H for emacs-devel@gnu.org; Mon, 04 Mar 2024 11:19:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhB2c-0000my-C6; Mon, 04 Mar 2024 11:19:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=PNMXH14MTvQ6jxf8QFa48UrolufzWoVbX4lkfh9L7uo=; b=NLER0+qjI+ITH0KaWDGV zc7/UzZ+Nl1oU/5/yYr981Ndy9H7Z8SyqhSa2UGt5aPIYQBOaCxgoP2IIwKimFZnhhCoQZRWWGyIH fWRLk1bT69ERZK+ShpvvD17UhNLKMvfcB3oYU/bmk/Z+knOSHgiEjQj4uFuLzZeARQrnvBRTPgGDg siBMf+FzD7GIgUiaPGZdZnYnsQwSuJgizEe/aKczghyw6YKWpGrKyZ2hAfM6xgbeu6epOevOegJfc iNy0GvAc6NuVBJ+Ezm/GzEDCxERi/DsyHDHKiBAKv5eKcP1/bwETlgf0qLM+K4s9lAKl7E3XTihP8 7LnnuQm+2IINZA==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rhB2b-00086S-Lz; Mon, 04 Mar 2024 11:19:50 -0500 In-Reply-To: (Stefan Monnier's message of "Mon, 04 Mar 2024 10:55:13 -0500") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316801 Archived-At: Stefan Monnier writes: >>> I'm not sure I understand. Is some code relying on the "order" of the >>> supertypes? Are these the regression you are mentioning? >>> Must say I'm surprised supertypes can have an "order" in first place. > > Hmm... a lot of what I've been talking about in this thread is about the > order of parents in `cl--typeof-types`, so yes, the order is important. > It determines the priority between methods. I'm asking because I'd personally consider any program relying on of the parent order just buggy. IMO parents have just no order by definition. I'd be curious to see at least one example of such program before calling it regression or thinking about changing our code in order to support such order. >> Also, this commit makes etc/syncdoc-type-hierarchy.el not functional and >> our doc out of sync (it removes the comment asking to run >> etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as well >> =F0=9F=99=81). > > Duh, thanks for point it out, I'll update the code accordingly. Thanks no rush, (I myself still have to commit the Makefile magic that installs syncdoc-type-hierarchy output). Thanks Andrea