From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Wed, 06 Mar 2024 14:06:57 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 06 20:08:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhwcb-0006Aw-3c for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Mar 2024 20:08:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhwbi-0003BQ-Bn; Wed, 06 Mar 2024 14:07:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhwbh-0003BA-7z for emacs-devel@gnu.org; Wed, 06 Mar 2024 14:07:13 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhwbf-0007En-IL; Wed, 06 Mar 2024 14:07:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=toKpfnJszEbPq03xEnBdkgtTtj3GIXW66z8o98Nw1lg=; b=el3WLapQxGHgQSqD4mwU R9Xld+gJL2aQfTDDcE49m4fZ8R3PDXEF9QOudDfJA+PC488I6qFnAEg6PQsBy/3vCmEdcX8brjP7+ 6SQ0UmpOHvHSo88cTurBY5STH4Y5znibSvp8GOnHBxcCNNNEI/8Xm8so1q5WpxNmdxSqC8MCUrm9s 8aqVKeh/3lDkZRf4iyG72Cek+Lv6ryNiKYoN0nqS8+XJDz4ub4mBro5/jHlPO3DQ70CVTBUzRXArG e8Hbwng8TeI8vRL9O8dnBilRTmue0whgBVZWHyU5uewNOdRR9ltBjpWICUT3HLgbdnPLBMwHbtPoP avfr34fHtlpJJw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rhwbR-0004Pb-7q; Wed, 06 Mar 2024 14:07:09 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Mar 2024 12:09:56 -0500") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316863 Archived-At: Stefan Monnier writes: >> Okay I pushed the changes to render all preloaded types. > > Thanks. > > It needs a bit more work, I think: `ppss` is marked as being a subtype > of `atom` but it's a subtype of `list`. That probably affects all the > defstructs declared with (:type list), and arguably for those declared > with (:type array) the supertype should be `array` rather than `atom`. > [ One could also argue that they shouldn't be in there at all because we > can't actually recognize those objects as being of that type, but > maybe it's OK to keep them. ] Yes I believe this affects the compiler as well. I'd like to fix it, I just have to find some time to read some cl- code to understand how to distinguish them, the patch should be easy. Thanks Andrea