From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 17:11:35 -0400 Message-ID: References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> <87zfqqzm43.fsf@yahoo.com> <3PIe9r2EdB3_AfXh2PCLvHFUUfe3Lw_AzuftyFBUPSij-qEEJAjTQ9zz7BpqQuQhgzGYfc4XjRxkc_LDjDUKIaabmkrOGhosyxtPitzpqMg=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Po Lu , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 23:12:29 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRI8S-000AZX-Kj for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 23:12:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRI7e-0008FM-9t; Tue, 09 Jul 2024 17:11:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRI7c-0008FE-IP for emacs-devel@gnu.org; Tue, 09 Jul 2024 17:11:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRI7b-0007z6-JN; Tue, 09 Jul 2024 17:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cEU60Rjswv+HH+AywnvPfoMaaUSgWchPC8417VAisx4=; b=qVLcNjUACe1MSDJ2AMP+ Qw4gayObp2ocnG7bQWFJtbgnKjJESbybV06XlOh+8vgpvt5+krVNZ0rncu+mItUKN43hYpGrto4T0 QEyKZkRMgVeyp9r1Zq7yhUnueSXtVfdW7VKrwaJW82zdsBdoKZk0KBGItE3BmtwAQmKq08GykLbNk JwSCE+MD2b1kirPGgqXvCTExXr3j/OZhoYlMb2VI1veRCX1n+LSevCygOgphLXKQZGd9c4divhYmi ZW+MWH2x9jExQ9p6qRH5V+G3iXkZu/76yB6el7AzAqz7fNeMPU4iqaYxilA3AJu/kP01uTxqnq0sX NJsSDcdL93SUaw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sRI7b-0008RF-9f; Tue, 09 Jul 2024 17:11:35 -0400 In-Reply-To: <3PIe9r2EdB3_AfXh2PCLvHFUUfe3Lw_AzuftyFBUPSij-qEEJAjTQ9zz7BpqQuQhgzGYfc4XjRxkc_LDjDUKIaabmkrOGhosyxtPitzpqMg=@protonmail.com> (Pip Cet's message of "Tue, 09 Jul 2024 17:19:37 +0000") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321569 Archived-At: Pip Cet writes: > On Tuesday, July 9th, 2024 at 14:16, Po Lu wrote: >> Andrea Corallo acorallo@gnu.org writes: >> > Pip Cet pipcet@protonmail.com writes: >> > >> > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org wrote: >> > > >> > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes: >> > > > >> > > > > branch: scratch/igc >> > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 >> > > > > Author: Pip Cet pipcet@protonmail.com >> > > > > Commit: Pip Cet pipcet@protonmail.com >> > > > > >> > > > > Fix GTK-related MPS crashes >> > > > > >> > > > > * src/gtkutil.c (free_glib_user_data): New function. >> > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. >> > > > > (qttip_cb, xg_create_frame_widgets) >> > > > > (xg_create_frame_outer_widgets, create_dialog) >> > > > > (make_cl_data, unref_cl_data, xg_mark_data) >> > > > > (menuitem_highlight_callback, xg_create_one_menuitem) >> > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) >> > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar) >> > > > > (xg_im_context_commit, xg_widget_style_updated) >> > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'. >> > > > > (xg_initialize): Remove linked list if HAVE_MPS. >> > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper >> > > > > functions. >> > > > > * src/xmenu.c (menubar_selection_callback) >> > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'. >> > > > >> > > > Hello, >> > > > >> > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only >> > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the >> > > > following on my system: >> > > >> > > Thank you! Can you let me know which gtk/glib version that is? I'd >> > > like to check the source code to make sure we can pass the right >> > > flag instead. >> > > >> > > I think we're okay just passing 0 instead. >> > > >> > > Pip >> > >> > Should be GTK 3.24.33 and glib 2.0. >> >> >> Passing 0 is correct. > > Thank you both, just pushed a fix. Please let me know if it isn't working. Builds again here thanks Andrea