From: Andrea Corallo <acorallo@gnu.org>
To: Pip Cet <pipcet@protonmail.com>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes
Date: Tue, 09 Jul 2024 17:11:35 -0400 [thread overview]
Message-ID: <yp1jzhue0e0.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <3PIe9r2EdB3_AfXh2PCLvHFUUfe3Lw_AzuftyFBUPSij-qEEJAjTQ9zz7BpqQuQhgzGYfc4XjRxkc_LDjDUKIaabmkrOGhosyxtPitzpqMg=@protonmail.com> (Pip Cet's message of "Tue, 09 Jul 2024 17:19:37 +0000")
Pip Cet <pipcet@protonmail.com> writes:
> On Tuesday, July 9th, 2024 at 14:16, Po Lu <luangruo@yahoo.com> wrote:
>> Andrea Corallo acorallo@gnu.org writes:
>> > Pip Cet pipcet@protonmail.com writes:
>> >
>> > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org wrote:
>> > >
>> > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes:
>> > > >
>> > > > > branch: scratch/igc
>> > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372
>> > > > > Author: Pip Cet pipcet@protonmail.com
>> > > > > Commit: Pip Cet pipcet@protonmail.com
>> > > > >
>> > > > > Fix GTK-related MPS crashes
>> > > > >
>> > > > > * src/gtkutil.c (free_glib_user_data): New function.
>> > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS.
>> > > > > (qttip_cb, xg_create_frame_widgets)
>> > > > > (xg_create_frame_outer_widgets, create_dialog)
>> > > > > (make_cl_data, unref_cl_data, xg_mark_data)
>> > > > > (menuitem_highlight_callback, xg_create_one_menuitem)
>> > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets)
>> > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar)
>> > > > > (xg_im_context_commit, xg_widget_style_updated)
>> > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_data'.
>> > > > > (xg_initialize): Remove linked list if HAVE_MPS.
>> > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper
>> > > > > functions.
>> > > > > * src/xmenu.c (menubar_selection_callback)
>> > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'.
>> > > >
>> > > > Hello,
>> > > >
>> > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only
>> > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the
>> > > > following on my system:
>> > >
>> > > Thank you! Can you let me know which gtk/glib version that is? I'd
>> > > like to check the source code to make sure we can pass the right
>> > > flag instead.
>> > >
>> > > I think we're okay just passing 0 instead.
>> > >
>> > > Pip
>> >
>> > Should be GTK 3.24.33 and glib 2.0.
>>
>>
>> Passing 0 is correct.
>
> Thank you both, just pushed a fix. Please let me know if it isn't working.
Builds again here thanks
Andrea
next prev parent reply other threads:[~2024-07-09 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org>
[not found] ` <20240704160812.55782C2BC72@vcs2.savannah.gnu.org>
2024-07-09 12:28 ` scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Andrea Corallo
2024-07-09 13:58 ` Pip Cet
2024-07-09 14:12 ` Andrea Corallo
2024-07-09 14:16 ` Po Lu
2024-07-09 17:19 ` Pip Cet
2024-07-09 21:11 ` Andrea Corallo [this message]
2024-07-11 2:32 ` Richard Stallman
2024-07-13 20:35 ` Pip Cet
2024-07-14 2:49 ` Gerd Möllmann
2024-07-15 10:24 ` Andrea Corallo
2024-07-24 3:02 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1jzhue0e0.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).