From: Andrea Corallo <acorallo@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: Helmut Eller <eller.helmut@gmail.com>,
Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
pipcet@protonmail.com, emacs-devel@gnu.org
Subject: Re: MPS: assertion failed: header_type (h) != IGC_OBJ_FWD
Date: Thu, 18 Jul 2024 15:06:38 -0400 [thread overview]
Message-ID: <yp1ed7qa5a9.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m2a5ieagaz.fsf@pro2.fritz.box> ("Gerd Möllmann"'s message of "Thu, 18 Jul 2024 17:08:36 +0200")
Gerd Möllmann <gerd.moellmann@gmail.com> writes:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>>
>>> Let's see if it continues crashing.
>>
>> It does :-(.
>
> Next idea.
>
> I wonder if __builtin_unwind_init changes things. The different
> behaviour when compiled -O0 and -O, the fact that problems happen in
> "random" places which lets me suspect indicates a basic problem, and so
> on - that would fit, when MPS doesn't see something in a register.
> Maybe.
>
> I'm now running with a patch that adds that to MPS' stack scanning code.
>
> @@ -39,6 +39,8 @@ void StackHot(void **stackOut);
> /* STACK_CONTEXT_BEGIN -- save context */
>
> #define STACK_CONTEXT_BEGIN(arena) \
> + BEGIN \
> + __builtin_unwind_init(); \
> BEGIN \
> StackContextStruct _sc; \
> STACK_CONTEXT_SAVE(&_sc); \
> @@ -51,6 +53,7 @@ void StackHot(void **stackOut);
> /* STACK_CONTEXT_END -- clear context */
>
> #define STACK_CONTEXT_END(arena) \
> + END; \
> END; \
> AVER(arena->stackWarm != NULL); \
> arena->stackWarm = NULL; \
>
> If somone observes similar strange phenomena like I do on macOS/arm64,
> maybe also give it a try.
>
> Let's see how long igc survives this time :-).
Hi Gerd,
if you want to use '__builtin_unwind_init' be aware that this GCC bug
I've found sometime ago [1] might make the builtin ineffective. It
might not effect your generated code but in case you need you can see
how we work it around in 'flush_stack_call_func'.
Regards
Andrea
[1] <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115132>
next prev parent reply other threads:[~2024-07-18 19:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 4:12 MPS: assertion failed: header_type (h) != IGC_OBJ_FWD Gerd Möllmann
2024-07-14 5:30 ` Pip Cet
2024-07-14 7:00 ` Gerd Möllmann
2024-07-14 7:08 ` Gerd Möllmann
2024-07-16 13:02 ` Gerd Möllmann
2024-07-16 13:38 ` Eli Zaretskii
2024-07-16 13:47 ` Gerd Möllmann
2024-07-16 14:11 ` Eli Zaretskii
2024-07-16 14:39 ` Gerd Möllmann
2024-07-16 15:21 ` Eli Zaretskii
2024-07-16 16:54 ` Gerd Möllmann
2024-07-16 14:19 ` Helmut Eller
2024-07-16 14:48 ` Gerd Möllmann
2024-07-16 15:22 ` Eli Zaretskii
2024-07-16 16:13 ` Pip Cet
2024-07-16 16:47 ` Gerd Möllmann
2024-07-17 7:51 ` Andrea Corallo
2024-07-17 19:47 ` Gerd Möllmann
2024-07-18 15:08 ` Gerd Möllmann
2024-07-18 16:05 ` Pip Cet
2024-07-18 16:33 ` Gerd Möllmann
2024-07-18 19:06 ` Andrea Corallo [this message]
2024-07-18 19:33 ` Gerd Möllmann
2024-07-19 4:38 ` Gerd Möllmann
2024-07-23 0:36 ` Pip Cet
2024-07-23 3:31 ` Gerd Möllmann
2024-07-16 15:49 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1ed7qa5a9.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).