unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 9ccd459e845: Enable xterm-mouse-mode by default in xterm
       [not found] ` <20241212105159.B81A566E610@vcs3.savannah.gnu.org>
@ 2024-12-12 12:21   ` Andrea Corallo
  2024-12-13  8:39   ` Michael Albinus
  1 sibling, 0 replies; 2+ messages in thread
From: Andrea Corallo @ 2024-12-12 12:21 UTC (permalink / raw)
  To: emacs-devel; +Cc: Jared Finder

Eli Zaretskii <eliz@gnu.org> writes:

> branch: master
> commit 9ccd459e8452cc9e6e81e53f26bbeef20d2d5bb7
> Author: Jared Finder <jared@finder.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Enable xterm-mouse-mode by default in xterm
>     
>     * lisp/xt-mouse.el (xterm-mouse-mode): Change default value of
>     xterm-mouse-mode to t.
>     * lisp/term/xterm.el (xterm--init): Enable xterm-mouse-mode if
>     the default value is still set.
>     * etc/NEWS: Document new behavior.

Hi Jared,

this introducing in my GNU/Linux build:

FAILED  3/3  xt-mouse-tracking-utf-8 (0.000543 sec) at lisp/xt-mouse-tests.el:79                                                                 
FAILED  2/3  xt-mouse-tracking-sgr (0.000810 sec) at lisp/xt-mouse-tests.el:101                                                                  
FAILED  1/3  xt-mouse-tracking-basic (0.228961 sec) at lisp/xt-mouse-tests.el:60

could you have a look?

More details below

Thanks

  Andrea


Test xt-mouse-tracking-basic backtrace:                                                                                                                                                    
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous                                                                                                                     
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                      
  #f(compiled-function () #<bytecode 0xcaea9a576e5cb44>)()                                                                                                                                 
  #f(compiled-function () #<bytecode -0xc1ae07004a64ed3>)()                                                                                                                                
  handler-bind-1(#f(compiled-function () #<bytecode -0xc1ae07004a64ed3                                                                                                                     
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test                                                                                                                     
  ert-run-test(#s(ert-test :name xt-mouse-tracking-basic :documentatio                                                                                                                     
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi                                                                                                                     
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n                                                                                                                     
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (                                                                                                                     
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un                                                                                                                     
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (                                                                                                                     
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l                                                                                                                     
  command-line()                                                                                                                                                                           
  normal-top-level()                                                                                                                                                                       
Test xt-mouse-tracking-basic condition:                                                                                                                                                    
    (ert-test-failed                                                                                                                                                                       
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                            
      (terminal-parameter nil xterm-mouse-mode) :value nil))                                                                                                                               
   FAILED  1/3  xt-mouse-tracking-basic (0.220402 sec) at lisp/xt-mouse-tests.el:60                                                                                                        
Test xt-mouse-tracking-sgr backtrace:                                                                                                                                                      
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous                                                                                                                     
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                      
  #f(compiled-function () #<bytecode 0xadf3ba82df72fe8>)()                                                                                                                                 
  #f(compiled-function () #<bytecode -0xc1ae07004a64ed3>)()                                                                                                                                
  handler-bind-1(#f(compiled-function () #<bytecode -0xc1ae07004a64ed3                                                                                                                     
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test                                                                                                                     
  ert-run-test(#s(ert-test :name xt-mouse-tracking-sgr :documentation                                                                                                                      
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...))                                                                                                                     
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n                                                                                                                     
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (                                                                                                                     
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un                                                                                                                     
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (                                                                                                                     
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l                                                                                                                     
  command-line()                                                                                                                                                                           
  normal-top-level()
Test xt-mouse-tracking-sgr condition:                                                                                                                                                      
    (ert-test-failed                                                                                                                                                                       
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                            
      (terminal-parameter nil xterm-mouse-mode) :value nil))                                                                                                                               
   FAILED  2/3  xt-mouse-tracking-sgr (0.000581 sec) at lisp/xt-mouse-tests.el:101                                                                                                         
Test xt-mouse-tracking-utf-8 backtrace:                                                                                                                                                    
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous                                                                                                                     
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                      
  #f(compiled-function () #<bytecode -0x1be7e949ea0313ce>)()                                                                                                                               
  #f(compiled-function () #<bytecode -0xc1ae07004a64ed3>)()                                                                                                                                
  handler-bind-1(#f(compiled-function () #<bytecode -0xc1ae07004a64ed3                                                                                                                     
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test                                                                                                                     
  ert-run-test(#s(ert-test :name xt-mouse-tracking-utf-8 :documentatio                                                                                                                     
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...                                                                                                                      
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n                                                                                                                     
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (                                                                                                                     
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un                                                                                                                     
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (                                                                                                                     
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l                                                                                                                     
  command-line()                                                                                                                                                                           
  normal-top-level()                                                                                                                                                                       
Test xt-mouse-tracking-utf-8 condition:                                                                                                                                                    
    (ert-test-failed                                                                                                                                                                       
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form                                                                                                                            
      (terminal-parameter nil xterm-mouse-mode) :value nil)) 



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 9ccd459e845: Enable xterm-mouse-mode by default in xterm
       [not found] ` <20241212105159.B81A566E610@vcs3.savannah.gnu.org>
  2024-12-12 12:21   ` master 9ccd459e845: Enable xterm-mouse-mode by default in xterm Andrea Corallo
@ 2024-12-13  8:39   ` Michael Albinus
  1 sibling, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2024-12-13  8:39 UTC (permalink / raw)
  To: emacs-devel; +Cc: Jared Finder

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

Hi,

> branch: master
> commit 9ccd459e8452cc9e6e81e53f26bbeef20d2d5bb7
> Author: Jared Finder <jared@finder.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Enable xterm-mouse-mode by default in xterm
>
>     * lisp/xt-mouse.el (xterm-mouse-mode): Change default value of
>     xterm-mouse-mode to t.
>     * lisp/term/xterm.el (xterm--init): Enable xterm-mouse-mode if
>     the default value is still set.
>     * etc/NEWS: Document new behavior.

This fails xt-mouse-tests:

--8<---------------cut here---------------start------------->8---
# make -C test xt-mouse-tests.log

Ran 3 tests, 0 results as expected, 3 unexpected (2024-12-13 09:35:08+0100, 1.359088 sec)

3 unexpected results:
   FAILED  xt-mouse-tracking-basic
   FAILED  xt-mouse-tracking-sgr
   FAILED  xt-mouse-tracking-utf-8
--8<---------------cut here---------------end--------------->8---

See appended log file.

Best regards, Michael.


[-- Attachment #2: xt-mouse-tests.log --]
[-- Type: text/plain, Size: 6648 bytes --]

Running 3 tests (2024-12-13 09:35:06+0100, selector `(not (tag :unstable))')
Test xt-mouse-tracking-basic backtrace:
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form
  (if (unwind-protect (setq value-14 (apply fn-12 args-13)) (setq form
  (let (form-description-16) (if (unwind-protect (setq value-14 (apply
  (let ((value-14 'ert-form-evaluation-aborted-15)) (let (form-descrip
  (let* ((fn-12 #'terminal-parameter) (args-13 (condition-case err (li
  (progn (let ((value-10 (gensym "ert-form-evaluation-aborted-"))) (le
  (if xterm-mouse-mode (progn (let ((value-10 (gensym "ert-form-evalua
  (progn (set-terminal-parameter nil 'xterm-mouse-last-click nil) (set
  (unwind-protect (progn (set-terminal-parameter nil 'xterm-mouse-last
  (let* ((old (terminal-parameter nil 'xterm-mouse-last-click)) (old (
  (progn (set-frame-width nil (max width 2000)) (set-frame-height nil
  (unwind-protect (progn (set-frame-width nil (max width 2000)) (set-f
  (let ((width (frame-width)) (height (frame-height))) (unwind-protect
  #f(lambda () [t] (let* ((fn-0 #'equal) (args-1 (condition-case err .
  #f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name xt-mouse-tracking-basic :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test xt-mouse-tracking-basic condition:
    (ert-test-failed
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form
      (terminal-parameter nil xterm-mouse-mode) :value nil))
   FAILED  1/3  xt-mouse-tracking-basic (0.170322 sec) at lisp/xt-mouse-tests.el:60
Test xt-mouse-tracking-sgr backtrace:
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form
  (if (unwind-protect (setq value-152 (apply fn-150 args-151)) (setq f
  (let (form-description-154) (if (unwind-protect (setq value-152 (app
  (let ((value-152 'ert-form-evaluation-aborted-153)) (let (form-descr
  (let* ((fn-150 #'terminal-parameter) (args-151 (condition-case err (
  (progn (let ((value-148 (gensym "ert-form-evaluation-aborted-"))) (l
  (if xterm-mouse-mode (progn (let ((value-148 (gensym "ert-form-evalu
  (progn (set-terminal-parameter nil 'xterm-mouse-last-click nil) (set
  (unwind-protect (progn (set-terminal-parameter nil 'xterm-mouse-last
  (let* ((old (terminal-parameter nil 'xterm-mouse-last-click)) (old (
  (progn (set-frame-width nil (max width 2000)) (set-frame-height nil
  (unwind-protect (progn (set-frame-width nil (max width 2000)) (set-f
  (let ((width (frame-width)) (height (frame-height))) (unwind-protect
  #f(lambda () [t] (let ((width (frame-width)) (height (frame-height))
  #f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name xt-mouse-tracking-sgr :documentation
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test xt-mouse-tracking-sgr condition:
    (ert-test-failed
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form
      (terminal-parameter nil xterm-mouse-mode) :value nil))
   FAILED  2/3  xt-mouse-tracking-sgr (0.000246 sec) at lisp/xt-mouse-tests.el:101
Test xt-mouse-tracking-utf-8 backtrace:
  signal(ert-test-failed (((should (terminal-parameter nil 'xterm-mous
  ert-fail(((should (terminal-parameter nil 'xterm-mouse-mode)) :form
  (if (unwind-protect (setq value-88 (apply fn-86 args-87)) (setq form
  (let (form-description-90) (if (unwind-protect (setq value-88 (apply
  (let ((value-88 'ert-form-evaluation-aborted-89)) (let (form-descrip
  (let* ((fn-86 #'terminal-parameter) (args-87 (condition-case err (li
  (progn (let ((value-84 (gensym "ert-form-evaluation-aborted-"))) (le
  (if xterm-mouse-mode (progn (let ((value-84 (gensym "ert-form-evalua
  (progn (set-terminal-parameter nil 'xterm-mouse-last-click nil) (set
  (unwind-protect (progn (set-terminal-parameter nil 'xterm-mouse-last
  (let* ((old (terminal-parameter nil 'xterm-mouse-last-click)) (old (
  (progn (set-frame-width nil (max width 2000)) (set-frame-height nil
  (unwind-protect (progn (set-frame-width nil (max width 2000)) (set-f
  (let ((width (frame-width)) (height (frame-height))) (unwind-protect
  (let ((xterm-mouse-utf-8 t)) (let* ((fn-74 #'equal) (args-75 (condit
  #f(lambda () [t] (let ((xterm-mouse-utf-8 t)) (let* ((fn-74 ...) (ar
  #f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x3549b7f7f1fe0b7
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name xt-mouse-tracking-utf-8 :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test xt-mouse-tracking-utf-8 condition:
    (ert-test-failed
     ((should (terminal-parameter nil 'xterm-mouse-mode)) :form
      (terminal-parameter nil xterm-mouse-mode) :value nil))
   FAILED  3/3  xt-mouse-tracking-utf-8 (0.000274 sec) at lisp/xt-mouse-tests.el:79

Ran 3 tests, 0 results as expected, 3 unexpected (2024-12-13 09:35:08+0100, 1.359088 sec)

3 unexpected results:
   FAILED  xt-mouse-tracking-basic
   FAILED  xt-mouse-tracking-sgr
   FAILED  xt-mouse-tracking-utf-8


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-13  8:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <173400071920.1603224.9897683501673718041@vcs3.savannah.gnu.org>
     [not found] ` <20241212105159.B81A566E610@vcs3.savannah.gnu.org>
2024-12-12 12:21   ` master 9ccd459e845: Enable xterm-mouse-mode by default in xterm Andrea Corallo
2024-12-13  8:39   ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).