From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Wed, 18 Dec 2024 07:55:17 -0500 Message-ID: References: <86seqmm9dq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35310"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org, pipcet@protonmail.com, monnier@iro.umontreal.ca To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 13:55:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNtaa-0008zz-QZ for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 13:55:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNtaL-0002cC-2t; Wed, 18 Dec 2024 07:55:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNtaG-0002bp-7n for emacs-devel@gnu.org; Wed, 18 Dec 2024 07:55:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNtaE-0006Mw-4B; Wed, 18 Dec 2024 07:55:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=eLjXyKCyaOK3M4d7QlnM8o/rTT/6o82LUdYU4ZcH4aE=; b=hmZeMx+ZFvI0hvqQt0VP rf3sFfv7PgdwlH3AohJFVa+AJ8pkvXbZT2ihRX6LDLZ6xvUivsc6Si48EJ4RzFPdituRzv1xH7ZYT B8IElXsifaTJmMAeyvkHs82CltD8lZc9Ny3wsaSqlbJ8XhElBYpMjOdmBlMibjt4tnp5WRmEDVc44 Pr4+e71XHUOKkXTrUJX6NCCYUvmQt+3/uZMxCiy4xHTuSzwrnRKxEw9ckHz/qMSmU1Se5UhuR8t4l BihWPA7MmQEO+r90Y7n/CDDojosSNoKRHFDQQpMpWiEJFA9gOKyjIllJ8xMH4RVTDcZFPIEcHHAXb E0kzY+WJC1XBzQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1tNta9-00071G-DT; Wed, 18 Dec 2024 07:55:18 -0500 In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llmann=22'?= =?utf-8?Q?s?= message of "Tue, 17 Dec 2024 19:56:59 +0100") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326644 Archived-At: Gerd M=C3=B6llmann writes: > Eli Zaretskii writes: > >>> From: Gerd M=C3=B6llmann >>> Cc: emacs-devel@gnu.org, Pip Cet , Stefan Monn= ier >>> >>> Date: Tue, 17 Dec 2024 18:56:05 +0100 >>>=20 >>> Gerd M=C3=B6llmann writes: >>>=20 >>> > Gerd M=C3=B6llmann writes: >>> > >>> >> I think check_comp_unit_relocs should be removed in the branch. What= 's >>> >> left of it the branch, checks in master if everything has been >>> >> put in purespace which should be there. IIUC correctly, of course. >>> > >>> > Patch attached. >>>=20 >>> Pushed. Complaints to me please. >> >> I'd like at least Andrea to take a look and confirm. > > It's 81fc23b5d6a60ca4f3d269ab2c88eb9a850bac4c Hi Gerd, looking at the commit now, why do you think 'check_comp_unit_relocs' should be removed?=20=20 Even if now the situation is simpler 'check_comp_unit_relocs' is still performing some sanity checks like if lambdas are all been fixed-up and present in 'comp_u->lambda_gc_guard_h'. Andrea