From: Andrea Corallo <acorallo@gnu.org>
To: Michael Albinus <Michael.Albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: Flickering tests
Date: Tue, 09 Jul 2024 04:39:33 -0400 [thread overview]
Message-ID: <yp1a5irez7e.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87bk3c70jj.fsf@gmx.de> (Michael Albinus's message of "Fri, 05 Jul 2024 09:36:32 +0200")
Michael Albinus <Michael.Albinus@gmx.de> writes:
> Andrea Corallo <acorallo@gnu.org> writes:
>
> Hi Andrea,
>
>> Mmmh not sure is possible but also desirable, we want to be able to run
>> as many tests as possible even with -jN.
>
> Last days, I've digged further into this. I still couldn't provoke the
> error (my machine has only 8 processing units). However, ...
>
>>> Btw, could you check whether the D-Bus tests flickery goes away if we
>>> tag dbus-test05-register-signal-with-nils as :unstable?
>>
>> From the bunch of test I did seems this is solving, I'll mark it as
>> :unstable for now till a better solution is found.
>
> ... I've found suspicious code in this test. Usually, all tests work
> deterministic. A method call or a signal is raised, and the returned
> message from D-Bus is analyzed. But in this test, a signal handler with
> a wildcard filter is registered. That means, *any* signal from D-Bus is
> catched, also signals which aren't relevant for this test. The more
> pressure you give on the system ("make -j96"), the more likely it is.
>
> So I have modified the signal handler to handle only signals we're
> interested in. See the appended patch. Could you, pls, check whether it
> helps? I guess we need it only in the master branch, because the problem
> appears only in dbus-test.el. dbusbind.c and dbus.el are OK.
Hi Michael,
I tried your patch and seems to solve (for my few tries at least). But
why do you think we need it only on master? Before being marked as
unstable the test was flickering on emacs-30 as well.
Thanks
Andrea
next prev parent reply other threads:[~2024-07-09 8:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 9:47 Flickering tests Andrea Corallo
2024-07-02 12:43 ` Andrea Corallo
2024-07-03 1:47 ` john muhl
2024-07-03 7:25 ` Andrea Corallo
2024-07-03 20:14 ` Stefan Kangas
2024-07-04 19:41 ` john muhl
2024-07-02 14:28 ` Michael Albinus
2024-07-02 15:25 ` Andrea Corallo
2024-07-03 14:52 ` Andrea Corallo
2024-07-03 15:39 ` Michael Albinus
2024-07-03 18:16 ` Andrea Corallo
2024-07-05 7:36 ` Michael Albinus
2024-07-09 8:39 ` Andrea Corallo [this message]
2024-07-09 8:49 ` Michael Albinus
2024-07-09 9:47 ` Andrea Corallo
2024-07-09 10:47 ` Michael Albinus
2024-07-09 12:30 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1a5irez7e.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=Michael.Albinus@gmx.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).