From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: MPS: Please check if scratch/igc builds with native compilation Date: Thu, 23 May 2024 03:38:13 -0400 Message-ID: References: <87r0du5rly.fsf@gmail.com> <87le425p8i.fsf@gmail.com> <87ed9u5lbi.fsf@gmail.com> <87v8356ngc.fsf@gmail.com> <87r0dt6lyq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Emacs Devel , Eli Zaretskii To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 23 09:38:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sA32M-00044m-3l for ged-emacs-devel@m.gmane-mx.org; Thu, 23 May 2024 09:38:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA31u-0006R2-QG; Thu, 23 May 2024 03:38:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA31s-0006QF-1W for emacs-devel@gnu.org; Thu, 23 May 2024 03:38:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA31k-0002tj-8X; Thu, 23 May 2024 03:38:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=td/jA+Qyf5SKuWUMOYGVTkvkiC2j57+O9AWK4ATiULk=; b=Bj7v43vqQ4UWX2mKbsxU SwF7HyJ0VZp8LpBqvFTEMcR+U2t3gNGlR80OwsXPlChY5Q3eiifUMlTQ8RsvSPBuPQsUFuyUQT42J OlD2RJOd552EngkFA4t08AZfgOuJrXrX07y36iiGswhLezDt6aY9bDA8TEIcw8FpxWKpf9eIQndzO 5KW5vNELsru053t6XjcODhgjIcmbPWGuirWVR+/z1yDLMw6+y8Mvi92nOsKIGxcDq05oVIoQ4Hnmv eJLPIUZ28wpcRLHPNxRPD2DBCyprdTyn5rgYOP/9bhgYZt3tt9T+CBIwpqTkEGWJR06NwemAJQlDd 4Ex1qKBVCqtYaQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sA31h-0007W1-4p; Thu, 23 May 2024 03:38:15 -0400 In-Reply-To: <87r0dt6lyq.fsf@gmail.com> (Helmut Eller's message of "Thu, 23 May 2024 09:12:13 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319504 Archived-At: Helmut Eller writes: > On Thu, May 23 2024, Gerd M=C3=B6llmann wrote: > >> Helmut Eller writes: >> >>>> In summary, I think this is an improvement. >>> >>> I also think that roots should be registered before top_level_run is >>> executed. >> >> Could you please elaborate? > > AFAIU, top_level_run executes the top level code of a file. I.e. it > usually creates a lot of functions and puts them into the > symbol-function slots; for lambdas it puts the subr in d_reloc (see > comp--register-lambda). > > In general, top_level_run can trigger GC flips because it calls > make_subr a lot. It would be problematic if d_reloc where not traced > during those GC flips. +1 > text_data_reloc_eph probably too, but I have no > clue what that is for. 'd_reloc_eph' is data used only at load time and never again. Note that 'top_level_run' uses 'd_reloc' as well so yes I believe as well they need all to be tracked before 'top_level_run' runs. Andrea