From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: make check produces 25 failures and hangs (bug #65176). Date: Sat, 12 Aug 2023 15:09:36 -0400 Message-ID: References: <9e9bf73a-f7e8-24e2-bd3f-5f4e86baa65e@vodafonemail.de> <83zg2ygmwu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24216"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 12 21:10:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUu0S-00062N-3T for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Aug 2023 21:10:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUtzY-0002CK-OM; Sat, 12 Aug 2023 15:09:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUtzW-0002C8-Lm for emacs-devel@gnu.org; Sat, 12 Aug 2023 15:09:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUtzV-0001yO-4A; Sat, 12 Aug 2023 15:09:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=uOrpDv0FQearB48Z5GTZi605QUS1NdwLjZPCwbYrHBA=; b=dIh9nJvo6iVJk4LPFdWK Rqj9WokodnS88UDgY8PpfE6j38IA6tTpL4SmGHfQ+iT8HQ8QPNJGxU5jIOkzHXLVHKTvn0ldBbHKi ZP/r0i2IJeziFSxQoDuVjXnqgppkEOC6o1tE+Z8iNVxMtVj4TzKmkk56dJQgwXqTB/gE3FNugpm42 qwlZv0PS8krBej5BMdCNUMx8NoupF1kkapzrqWxABK/tlAJeUYf5yveYtZEmRR6wAe/+gU8H5ZgIx 0DCFzIlTLsEaY0eTqi7A0OWsBqDQjuj5KKVQE4GGm0A9MVLS5v3Ro3ec2ld+C6qNCOG6UX9hWmT+m pXMm59TFsKTiCg==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qUtzU-0000TN-4m; Sat, 12 Aug 2023 15:09:36 -0400 In-Reply-To: (Andrea Corallo's message of "Sat, 12 Aug 2023 14:03:48 -0400") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308627 Archived-At: Andrea Corallo writes: > Eli Zaretskii writes: > >>> Date: Thu, 10 Aug 2023 23:54:50 +0200 >>> Cc: emacs-devel@gnu.org >>> From: Jens Schmidt >>> >>> On 2023-08-10 22:34, Alan Mackenzie wrote: >>> >>> > So the bugs seem to be triggered by native compilation. >>> >>> Confirmed. And the hangs seem to be caused by tests asking for input. >>> >>> I executed one of these failing tests interactively >>> (lisp/abbrev-tests.el), and it kept prompting in the minibuffer >>> where the usual >>> >>> (cl-letf (((symbol-function 'read-string) (lambda (&rest _) ""))) >>> >>> should have inhibited that. Full output of that interactive test to >>> follow: >>> >>> Selector: t >>> Passed: 18 >>> Failed: 3 (3 unexpected) >>> Skipped: 1 >>> Total: 22/22 >>> >>> Started at: 2023-08-10 23:46:56+0200 >>> Finished. >>> Finished at: 2023-08-10 23:47:36+0200 >>> >>> .............FFFs..... >>> >>> F inverse-add-abbrev-skips-trailing-nonword >>> Test that adding an inverse abbrev skips trailing nonword characters. >>> (ert-test-failed >>> ((should (string= (abbrev-expansion "foo" table) "bar")) :form >>> (string= "abc" "bar") :value nil :explanation >>> (array-elt 0 (different-atoms (97 "#x61" "?a") (98 "#x62" "?b"))))) >>> >>> F inverse-add-abbrev-skips-trailing-nonword/negative-arg >>> Test that adding an inverse abbrev skips trailing nonword characters. >>> (ert-test-failed >>> ((should (string= (abbrev-expansion "text" table) "bar")) :form >>> (string= "xxx" "bar") :value nil :explanation >>> (array-elt 0 (different-atoms (120 "#x78" "?x") (98 "#x62" "?b"))))) >>> >>> F inverse-add-abbrev-skips-trailing-nonword/positive-arg >>> Test that adding an inverse abbrev skips trailing nonword characters. >>> (ert-test-failed >>> ((should (string= (abbrev-expansion "text" table) "bar")) :form >>> (string= "xxx" "bar") :value nil :explanation >>> (array-elt 0 (different-atoms (120 "#x78" "?x") (98 "#x62" "?b"))))) >> >> Andrea, could you please look into these test failures? > > Yes, will do on Monday. > > If in the meanwhile someone could git bisect this I guess it would be > make the investigation way quicker. > > Andrea To a very quick look seems to me `comp-subr-trampoline-install' is just not called as it should. AFAIR it should be called from Ffset, I'm really wondering what could have happened. Andrea