From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Tue, 05 Mar 2024 09:35:13 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 05 15:36:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhVu2-0006pL-R0 for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Mar 2024 15:36:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhVtA-0004U8-K4; Tue, 05 Mar 2024 09:35:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhVt8-0004Th-NL for emacs-devel@gnu.org; Tue, 05 Mar 2024 09:35:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhVt4-00077J-KD; Tue, 05 Mar 2024 09:35:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rWprXs3kjcdB9QQYS7oUk1jotuf7zY09drwoklncw+o=; b=VcaQMQrANVdtBKcDSiQ3 +tBSgyMpSi5Zy/46/QkaThpOaCfEHFS4BKnXxsXpta2fwlEqfz41fNlj2l9SjtqqLOpN+S1CoP1l5 +kleaBcb/GTCtL5Jhf+99SjOTYCydZiCkas+3ZUKKCKwDhQWPEhpiTGXq3/sIl5lj1LVHQXoDXklA +Z4QN1vnq9H/LyuikcTNFbX4L/Wk6hnjd6Gz0F1O7kxa0u64S35iYo7h/8QJLwi4kXIJlWCSBBbg6 WCv7Q5UfQR4ailfj2VqxkimP9VWcfcGs7m1WOd2C7hIb+Z+5BCrRz+eswJ3xO8KTRBRDetzGWNc+J jMQelemDzIpBcQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rhVsw-0002am-3r; Tue, 05 Mar 2024 09:35:20 -0500 In-Reply-To: (Stefan Monnier's message of "Mon, 04 Mar 2024 19:08:18 -0500") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316826 Archived-At: Stefan Monnier writes: >>>>> I'm not sure I understand. Is some code relying on the "order" of the >>>>> supertypes? Are these the regression you are mentioning? >>>>> Must say I'm surprised supertypes can have an "order" in first place. >>> Hmm... a lot of what I've been talking about in this thread is about the >>> order of parents in `cl--typeof-types`, so yes, the order is important. >>> It determines the priority between methods. >> I'm asking because I'd personally consider any program relying on of the >> parent order just buggy. > > Such dependencies are rare, indeed. They're rare enough that I wouldn't > have enough intuition to judge whether they reflect bugs or not. In any > case CLOS wants it, and I see no reason to do otherwise: the cl-generic > code needs to order the methods according to some criteria, so I prefer > to document that we do it like CLOS than to make it "undefined" (it'd be > extra work to try and detect such undefined cases, on top of that, so > instead we'd get "some arbitrary order" (like we have now) which we'd > have to preserve to avoid breaking backward compatibility: might as well > make this arbitrary order somewhat meaningful =F0=9F=99=82). > >>>> Also, this commit makes etc/syncdoc-type-hierarchy.el not functional a= nd >>>> our doc out of sync (it removes the comment asking to run >>>> etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as we= ll >>>> =F0=9F=99=81). >>> >>> Duh, thanks for point it out, I'll update the code accordingly. >> >> Thanks no rush, > > Done. > >> (I myself still have to commit the Makefile magic that >> installs syncdoc-type-hierarchy output). > > Haven't touched that, sorry. Np was in my todo already, should be done now. PS the DAG looks pretty cool now =F0=9F=99=82, I'm wondering tho if we shou= ld show as well types like transient*, which don't come preloaded. Andrea