From: Andrea Corallo <acorallo@gnu.org>
To: emacs-devel@gnu.org
Cc: Yuan Fu <casouri@gmail.com>
Subject: Re: master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode
Date: Mon, 02 Dec 2024 16:02:33 -0500 [thread overview]
Message-ID: <yp14j3lhk7q.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20241202021023.2C8B8521785@vcs3.savannah.gnu.org> (Yuan Fu's message of "Sun, 1 Dec 2024 21:10:23 -0500 (EST)")
Yuan Fu <casouri@gmail.com> writes:
> branch: master
> commit 63d69bd154987bcc0434e0f85e09bf5dfa07b827
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
> Use new baseline indent rule in c-ts-mode
>
> Rework the indent rules in c-ts-mode using
> c-ts-common-baseline-indent-rule. Also reworked internal
> functions for setting indent styles to make it simpler and (more
> importantly) more readable. Now there's a single function,
> c-ts-mode--simple-indent-rules, that returns a value that can go
> straight to treesit-simple-indent-rules.
>
> * lisp/progmodes/c-ts-mode.el:
> (c-ts-mode--indent-style-setter): Simplify.
> (c-ts-mode--get-indent-style): Remove function.
> (c-ts-mode--prompt-for-style): Use a hard-coded list of styles.
> This is a tiny downgrade from the computed lists but is
> acceptable.
> (c-ts-mode-set-style): Use c-ts-mode--simple-indent-rules.
> (c-ts-mode--standalone-grandparent): Docstring change.
> (c-ts-mode--for-loop-indent-rule): New function.
> (c-ts-mode--preproc-indent-rules): New variable. Copied from
> old indent rules and added some new rule.
> (c-ts-mode--macro-heuristic-rules):
> (c-ts-mode--simple-indent-rules):
> (c-ts-mode--parenthesized-expression-indent-rule):
> (c-ts-mode--label-indent-rules): New functions.
> (c-ts-mode):
> (c++-ts-mode): Use c-ts-mode--simple-indent-rules.
> ---
Hi Yuan,
this commit on my test-bench seems to introduce on master the following
two failures: c-ts-mode-test-indentation-bsd,
c-ts-mode-test-indentation.
Could you have a look?
Andrea
next parent reply other threads:[~2024-12-02 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <173310542049.252624.8341603519407599366@vcs3.savannah.gnu.org>
[not found] ` <20241202021023.2C8B8521785@vcs3.savannah.gnu.org>
2024-12-02 21:02 ` Andrea Corallo [this message]
2024-12-03 0:38 ` master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode Yuan Fu
2024-12-03 8:05 ` Andrea Corallo
[not found] ` <20241202021023.5060A521787@vcs3.savannah.gnu.org>
2024-12-04 8:19 ` master 44fcd37a486 08/11: Add more c-ts-mode indent tests Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp14j3lhk7q.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).