From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Gnus: fix article to always display git diffs properly Date: Wed, 10 Jul 2024 17:55:51 -0400 Message-ID: References: <87v81dmhxi.fsf@orpheu.olymp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Luis Henriques Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 10 23:57:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRfJE-0000gY-5U for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jul 2024 23:57:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRfI8-00074X-E8; Wed, 10 Jul 2024 17:56:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRfI4-00074H-Sk for emacs-devel@gnu.org; Wed, 10 Jul 2024 17:55:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRfI3-0000G3-Bt; Wed, 10 Jul 2024 17:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lNovETcK16uFjj+re4aJO62K50WIbBZK42+952SKhEQ=; b=B9iMyE7ktjBJY7Xdr8mM Xn7oGBqxH7rJiG1hSn2fQZ88fMMX09mzwKFE5/IKdFWNyBD40VxlKLtakvIMdmJCKxbiwPYi38BZG eIkljWNQcE+GdDVc2zCf8WtWNsY7a+c+x2tl3IXLsQd0CVDcFS0abOJcbjuS1qxJeQT2yUYVAw6ap RsHSns+AnJOvWzNAh00Ip2Ae7VLjqF2vGyMrAZ5Du1mdB/GgJHFIeaqqyy/4ucigjn3P4bAp7uZZ6 ye/G/nSnC0iuo50JzGGHP9V3earF/XrbRPt4AUogRC6GJP9eYFLaXcA9c1XCnbOu5RoviEomLoadZ 4vOqr96G+TZXbw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sRfHz-0004XR-WF; Wed, 10 Jul 2024 17:55:55 -0400 In-Reply-To: <87v81dmhxi.fsf@orpheu.olymp> (Luis Henriques's message of "Wed, 10 Jul 2024 15:37:45 +0100") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321580 Archived-At: Luis Henriques writes: > Hi! > > It's been a while since I realised that some emails containing inline > patches generated with git aren't actually recognised as such in Gnus. > And today I finally decided to figure out why. Basically, it's because it > is assumed that those patches will end with a signature -- and that's not > always true. > > Below there's a one-liner that seems to fix it -- it's not thoroughly tested, > but nothing seems to break. Note that the other diff elements don't have > an 'end-point' either. Would this change be acceptable? > > (And also note that the patch does *not* have a signature at the end!) > > Cheers, Hi Luis, thanks, would you mind sending the patch following [1] so we can discuss and track it into the bug tracker? BR Andrea [1]