unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <acorallo@gnu.org>
To: Luis Henriques <henrix@camandro.org>
Cc: emacs-devel@gnu.org
Subject: Re: Gnus: fix article to always display git diffs properly
Date: Wed, 10 Jul 2024 17:55:51 -0400	[thread overview]
Message-ID: <yp134ogewt4.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87v81dmhxi.fsf@orpheu.olymp> (Luis Henriques's message of "Wed,  10 Jul 2024 15:37:45 +0100")

Luis Henriques <henrix@camandro.org> writes:

> Hi!
>
> It's been a while since I realised that some emails containing inline
> patches generated with git aren't actually recognised as such in Gnus.
> And today I finally decided to figure out why.  Basically, it's because it
> is assumed that those patches will end with a signature -- and that's not
> always true.
>
> Below there's a one-liner that seems to fix it -- it's not thoroughly tested,
> but nothing seems to break.  Note that the other diff elements don't have
> an 'end-point' either.  Would this change be acceptable?
>
> (And also note that the patch does *not* have a signature at the end!)
>
> Cheers,

Hi Luis,

thanks, would you mind sending the patch following [1] so we can discuss
and track it into the bug tracker?

BR

  Andrea

[1] <https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.html>



  reply	other threads:[~2024-07-10 21:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 14:37 Gnus: fix article to always display git diffs properly Luis Henriques
2024-07-10 21:55 ` Andrea Corallo [this message]
2024-07-11  8:14   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yp134ogewt4.fsf@fencepost.gnu.org \
    --to=acorallo@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=henrix@camandro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).