From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 08:28:52 -0400 Message-ID: References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2625"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pip Cet To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 14:30:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sR9z0-0000P5-9b for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 14:30:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR9xn-0000gz-MW; Tue, 09 Jul 2024 08:28:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR9xl-0000gJ-BR for emacs-devel@gnu.org; Tue, 09 Jul 2024 08:28:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR9xk-0005Kq-Oc; Tue, 09 Jul 2024 08:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=20r0vpGxt9HaSJ45JRrLTJJfspfQfpf0ZtIY2/fgAj0=; b=JF4A0TlrvNiiqAtfxI/S rm50DnfNjO6vz9i4sfWk80zsjvsgSRUhaTTk/KjZHIFKcpL/vsgilKGgmFCre9KRyX+ErGQNM9L5b GITAdsqa7QbigaSDMju2u5sQ8GIy1UpwS4KgoD4CEMdKTX9QEUGlGTpKpcMOAbrnq3TbD08Qo2Ehy 5FopGdxanroBeCx2v8BBCjX/HdnrgZILwKc05jx7SrmlVDWQGw635swyQ2qQOjpTxEh/cxl8r1Au/ Vit4dehGQsNbHIBVV5Tcpzba0x0YSQj5GogQjgPj1+NrFjt6oZ8YCg7gJzejgE37moFKqE2lO24Z7 BVoT/Lrn5NkTVw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sR9xk-0004Bx-88; Tue, 09 Jul 2024 08:28:52 -0400 In-Reply-To: <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> (Pip Cet via Mailing list for Emacs changes's message of "Thu, 4 Jul 2024 12:08:12 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321562 Archived-At: Pip Cet via Mailing list for Emacs changes writes: > branch: scratch/igc > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 > Author: Pip Cet > Commit: Pip Cet > > Fix GTK-related MPS crashes > > * src/gtkutil.c (free_glib_user_data): New function. > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. > (qttip_cb, xg_create_frame_widgets) > (xg_create_frame_outer_widgets, create_dialog) > (make_cl_data, unref_cl_data, xg_mark_data) > (menuitem_highlight_callback, xg_create_one_menuitem) > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) > (draw_page, xg_print_frames_dialog, xg_create_toolbar) > (xg_im_context_commit, xg_widget_style_updated) > (tb_size_cb): Adjust to use `get_glib_user_data' and > `g_signal_connect_data'. > (xg_initialize): Remove linked list if HAVE_MPS. > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper > functions. > * src/xmenu.c (menubar_selection_callback) > (popup_selection_callback): Adjust to use `get_glib_user_data'. Hello, as on my system gsignal.h does not define G_CONNECT_DEFAULT but only G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the following on my system: CC gtkutil.o gtkutil.c: In function =E2=80=98qttip_cb=E2=80=99: gtkutil.c:902:30: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (fi= rst use in this function) 902 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c:902:30: note: each undeclared identifier is reported only once fo= r each function it appears in gtkutil.c: In function =E2=80=98xg_create_frame_widgets=E2=80=99: gtkutil.c:1579:26: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 1579 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98create_dialog=E2=80=99: gtkutil.c:2406:36: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 2406 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98xg_create_one_menuitem=E2=80=99: gtkutil.c:3336:26: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 3336 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98create_menus=E2=80=99: gtkutil.c:3455:30: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 3455 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98xg_update_menu_item=E2=80=99: gtkutil.c:3931:40: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 3931 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98xg_update_frame_menubar=E2=80=99: gtkutil.c:4211:26: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 4211 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98xg_print_frames_dialog=E2=80=99: gtkutil.c:5317:26: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 5317 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ gtkutil.c: In function =E2=80=98xg_create_tool_bar=E2=80=99: gtkutil.c:5595:26: error: =E2=80=98G_CONNECT_DEFAULT=E2=80=99 undeclared (f= irst use in this function) 5595 | G_CONNECT_DEFAULT); | ^~~~~~~~~~~~~~~~~ Thanks Andrea