From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master bf0aeaa0d7a: Re-enable displaying `han' characters on Android Date: Thu, 01 Aug 2024 03:57:14 -0400 Message-ID: References: <86h6c5y39e.fsf@gnu.org> <87plqtf6m0.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 01 09:57:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZQh7-0009Rv-7w for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Aug 2024 09:57:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZQgX-0001hq-EJ; Thu, 01 Aug 2024 03:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZQgW-0001hQ-9B for emacs-devel@gnu.org; Thu, 01 Aug 2024 03:57:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZQgV-0005vy-VP; Thu, 01 Aug 2024 03:57:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=onlnhSTFwYBsni/8Q4KmZItAaHnylqnVwAX9IulB4ME=; b=OGzd9NypMJoAa2S629LV BXKkZeIWo+BEnOsbCXBD7BpA4gRsT5KFmsDPR6urDTwxAZB/STlIoK+USIN7QlxEpquPC4DQJFh+j yjKVsCbmiusD3xZY2aPtoHvstTJIHe7X95QJ28ci2s+P2Y3nSGVfc9gF6qf/eauL8B4LYr3MqcoHk PcSCbDajAlMp/DEd8/iHyYZnkMKP2oHH19NTYi9XJQQYiIbO/2jvCd3/d4F6ZJuXjW4AgNB6Q/Skx fbRy9tXdl7qkYsS413cXkaaeB0yw4YDY0cmUjadMinK7zSEzD/+ShJySZ5YpWsCKHjhywIgNS54X4 75Die4OM48XRrQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sZQgU-00076N-V7; Thu, 01 Aug 2024 03:57:15 -0400 In-Reply-To: <87plqtf6m0.fsf@yahoo.com> (Po Lu's message of "Thu, 01 Aug 2024 08:07:35 +0800") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322252 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >> I've reverted the above commit. The change which added those >> characters was not an accident: I found that Emacs would choose an >> inappropriate (sub-optimal) font for Chinese characters because it >> generally stops looking once it find the first font that fulfills the >> requirements. > > The reason behind your discovery is that with your choice of > `script-representative-chars', no font will ever match this font spec > (in the default fontset): > > ,(font-spec :registry "iso10646-1" :script 'han) > > so that Emacs returns to the preceding ones, which specify a design > language rather than a script: > > ,(font-spec :registry "iso10646-1" :lang 'ja) > ,(font-spec :registry "iso10646-1" :lang 'zh) > > which is supported elsewhere than on Android. > >> The font Emacs sometimes selects due to those characters missing >> lacked support for important Han blocks because those blocks had no >> characters in script-representative-chars. > > I didn't revert your change in whole, only characters beyond the BMP > that seldom appear in real Chinese writing; of the characters that were > deleted: Still, even if is not a complete revert, if you are undoing even partially a change by someone else, please discuss first why you'd want to do it on the list, especially if it's recent change. As this discussion proves the consequences of this change are not trivial. Thanks Andrea