From: bojohan+news@dd.chalmers.se (Johan Bockgård)
Subject: Re: Patch: Syntax and Hard Newlines
Date: Thu, 23 Nov 2006 10:33:05 +0100 [thread overview]
Message-ID: <yoijbqmy5wz2.fsf@gamma02.me.chalmers.se> (raw)
In-Reply-To: E1GkikB-0003Pw-F7@fencepost.gnu.org
Richard Stallman <rms@gnu.org> writes:
> However, unlike `assoc' which returns the matching cons,
> `assoc-default' returns the cdr. In the code in question it is always
> nil.
>
> Does this code work right?
>
> *** bytecomp.el 08 Jul 2006 16:59:45 -0400 2.186
> --- bytecomp.el 16 Nov 2006 08:24:45 -0500
> ***************
> *** 2864,2871 ****
>
> (defmacro byte-compile-get-constant (const)
> `(or (if (stringp ,const)
> ! (assoc-default ,const byte-compile-constants
> ! 'equal-including-properties nil)
> (assq ,const byte-compile-constants))
> (car (setq byte-compile-constants
> (cons (list ,const) byte-compile-constants)))))
> --- 2864,2875 ----
>
> (defmacro byte-compile-get-constant (const)
> `(or (if (stringp ,const)
> ! ;; In a string constant, treat properties as significant.
> ! (let (result)
> ! (dolist (elt byte-compile-constants)
> ! (if (equal-including-properties (car elt) ,const)
> ! (setq result elt)))
> ! result)
> (assq ,const byte-compile-constants))
> (car (setq byte-compile-constants
> (cons (list ,const) byte-compile-constants)))))
I think so.
Also, Chong removed the "Prevent byte compiler from causing spurious
string sharing when it optimizes away calls to functions such as
concat" note from FOR-RELEASE, but it doesn't seem like anything was
done about it.
--
Johan Bockgård
next prev parent reply other threads:[~2006-11-23 9:33 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 5:24 Patch: Syntax and Hard Newlines Herbert Euler
2006-11-13 5:52 ` Herbert Euler
2006-11-13 10:12 ` Herbert Euler
2006-11-13 20:15 ` Richard Stallman
2006-11-14 1:35 ` Herbert Euler
2006-11-15 3:14 ` Richard Stallman
2006-11-13 19:43 ` Stefan Monnier
2006-11-14 1:19 ` Herbert Euler
2006-11-14 6:51 ` Stefan Monnier
2006-11-14 7:35 ` Herbert Euler
2006-11-14 15:00 ` Stefan Monnier
2006-11-15 1:32 ` Herbert Euler
2006-11-15 3:58 ` Stefan Monnier
2006-11-15 4:24 ` Herbert Euler
2006-11-16 6:22 ` Richard Stallman
2006-11-30 6:36 ` Herbert Euler
2006-11-30 14:52 ` Stefan Monnier
2006-12-02 17:56 ` Richard Stallman
2006-12-07 18:46 ` Stefan Monnier
2006-12-08 5:04 ` Richard Stallman
2006-12-08 7:44 ` Stefan Monnier
2006-12-09 1:25 ` Richard Stallman
2006-12-09 3:50 ` Stefan Monnier
2006-12-09 18:25 ` Richard Stallman
2006-11-15 4:37 ` Herbert Euler
2006-11-15 7:26 ` Miles Bader
2006-11-15 14:03 ` Stefan Monnier
2006-11-15 15:47 ` Johan Bockgård
2006-11-15 16:37 ` Stefan Monnier
2006-11-16 15:01 ` Richard Stallman
2006-11-16 15:01 ` Richard Stallman
2006-11-23 9:33 ` Johan Bockgård [this message]
2006-11-14 12:27 ` Richard Stallman
2006-11-14 15:08 ` Stefan Monnier
2006-11-15 22:58 ` Richard Stallman
2006-11-13 20:15 ` Richard Stallman
2006-11-14 1:42 ` Herbert Euler
2006-11-14 8:36 ` Herbert Euler
2006-11-14 11:38 ` Herbert Euler
2006-11-14 15:03 ` Stefan Monnier
2006-11-16 6:23 ` Herbert Euler
2006-11-16 8:42 ` martin rudalics
2006-11-16 10:47 ` Herbert Euler
2006-11-16 12:18 ` martin rudalics
2006-11-16 12:37 ` Herbert Euler
2006-11-16 12:57 ` martin rudalics
2006-11-16 15:12 ` Herbert Euler
2006-11-16 16:03 ` martin rudalics
2006-11-17 1:24 ` Herbert Euler
2006-11-17 2:27 ` Stefan Monnier
2006-11-17 1:36 ` Herbert Euler
2006-11-16 14:22 ` Stefan Monnier
2006-11-17 6:30 ` Herbert Euler
2006-11-17 18:39 ` martin rudalics
2006-11-18 0:51 ` Herbert Euler
2006-11-18 14:34 ` martin rudalics
2006-11-18 15:21 ` Miles Bader
2006-11-19 11:11 ` martin rudalics
2006-11-19 18:14 ` Stefan Monnier
2006-11-20 1:37 ` Richard Stallman
2006-11-20 3:04 ` Stefan Monnier
2006-11-20 23:57 ` Richard Stallman
2006-11-21 0:03 ` David Kastrup
2006-11-22 13:15 ` Richard Stallman
2006-11-22 13:50 ` David Kastrup
2006-11-24 22:49 ` Richard Stallman
2006-11-26 11:42 ` Kim F. Storm
2006-11-26 12:08 ` David Kastrup
2006-11-26 18:32 ` Kim F. Storm
2006-11-26 19:53 ` David Kastrup
2006-12-05 17:43 ` David Reitter
2006-12-06 14:24 ` Richard Stallman
2006-12-08 9:03 ` David Reitter
2006-11-20 7:39 ` martin rudalics
2006-11-20 10:13 ` David Kastrup
2006-11-20 7:09 ` Herbert Euler
2006-11-20 8:03 ` martin rudalics
2006-11-19 0:58 ` Stefan Monnier
2006-11-19 12:47 ` Richard Stallman
2006-11-19 18:09 ` Stefan Monnier
2006-11-20 12:59 ` Richard Stallman
2006-11-21 3:45 ` Herbert Euler
2006-11-22 13:15 ` Richard Stallman
2006-11-23 3:27 ` Herbert Euler
2006-11-26 2:01 ` Richard Stallman
2006-11-27 1:10 ` Stefan Monnier
2006-11-29 4:06 ` Herbert Euler
2006-11-29 4:08 ` Herbert Euler
2006-11-29 4:57 ` Stefan Monnier
2006-11-29 7:36 ` Herbert Euler
2006-11-29 11:28 ` Stefan Monnier
2006-11-30 3:20 ` Richard Stallman
2006-11-29 8:13 ` David Kastrup
2006-11-19 7:59 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yoijbqmy5wz2.fsf@gamma02.me.chalmers.se \
--to=bojohan+news@dd.chalmers.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).