[bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[Richard Stallman]

Would someone please check that this is correct,
and if so install it and ack?

------- Start of forwarded message -------
From: bojohan+mail@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=)
To: emacs-pretest-bug@gnu.org
Date: Thu, 22 Feb 2007 19:57:57 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Subject: replace-regexp at end of buffer
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4


replace-regexp/perform-replace wrongly moves back a character when the
match is at end of buffer.

Run

   (perform-replace "abc" "123" nil t nil)

on a buffer that ends in "abc" (no final newline).

Point ends up between 2 and 3.

This is because point could not move too far in this case, and so the
following correction shouldn't be done [perform-replace]:

   ;; The code preventing adjacent regexp matches in the condition
   ;; of the while-loop above will haven taken us one character
   ;; beyond the last replacement.  Undo that.
   (when (and regexp-flag (not match-again) (> replace-count 0))
     (backward-char 1))


- -- 
Johan Bockgård


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

> Would someone please check that this is correct,
> and if so install it and ack?

perform-replace is a subroutine of query-replace, which does not
exhibit any problem (it corrects the buffer position when this case
occurs).  It is not used in generic Elisp code, which should be using
replace-match instead.

Therefore, no fix is required or desired.

> replace-regexp/perform-replace wrongly moves back a character when the
> match is at end of buffer.
>
> Run
>
>    (perform-replace "abc" "123" nil t nil)
>
> on a buffer that ends in "abc" (no final newline).
>
> Point ends up between 2 and 3.
>
> This is because point could not move too far in this case, and so the
> following correction shouldn't be done [perform-replace]:
>
>    ;; The code preventing adjacent regexp matches in the condition
>    ;; of the while-loop above will haven taken us one character
>    ;; beyond the last replacement.  Undo that.
>    (when (and regexp-flag (not match-again) (> replace-count 0))
>      (backward-char 1))

Re: [bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[Johan Bockgård]

Chong Yidong <cyd@stupidchicken.com> writes:

> perform-replace is a subroutine of query-replace, which does not
> exhibit any problem (it corrects the buffer position when this case
> occurs). It is not used in generic Elisp code, which should be using
> replace-match instead.
>
> Therefore, no fix is required or desired.

This affects regexp replacement. Try M-x replace-regexp (this command
was already mentioned), or query-replace-regexp if you like.

-- 
Johan Bockgård

Re: [bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[Richard Stallman]

    perform-replace is a subroutine of query-replace, which does not
    exhibit any problem (it corrects the buffer position when this case
    occurs).

The bug does not occur in query-replace, but it does occur
in query-replace-regexp.  Some fix is needed.

Can you fix it?

Re: [bojohan+mail@dd.chalmers.se: replace-regexp at end of buffer]

[Chong Yidong]

bojohan+news@dd.chalmers.se (Johan Bockgård) writes:

> Chong Yidong <cyd@stupidchicken.com> writes:
>
>> perform-replace is a subroutine of query-replace, which does not
>> exhibit any problem (it corrects the buffer position when this case
>> occurs). It is not used in generic Elisp code, which should be using
>> replace-match instead.
>>
>> Therefore, no fix is required or desired.
>
> This affects regexp replacement. Try M-x replace-regexp (this command
> was already mentioned), or query-replace-regexp if you like.

I see the problem now.  I've checked in a fix, thanks.