From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=) Newsgroups: gmane.emacs.devel Subject: Re: [bug] read-passwd of CVS Emacs Date: Wed, 24 May 2006 23:09:50 +0200 Message-ID: References: <20060524.123750.178780620.kazu@iij.ad.jp> <85u07f2xfq.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1148505041 14533 80.91.229.2 (24 May 2006 21:10:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 May 2006 21:10:41 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 24 23:10:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fj0ce-0000cR-3F for ged-emacs-devel@m.gmane.org; Wed, 24 May 2006 23:10:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj0cd-0004CY-ER for ged-emacs-devel@m.gmane.org; Wed, 24 May 2006 17:10:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fj0cS-0004CA-Lr for emacs-devel@gnu.org; Wed, 24 May 2006 17:10:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fj0cR-0004Bx-HG for emacs-devel@gnu.org; Wed, 24 May 2006 17:10:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj0cR-0004Bu-Bq for emacs-devel@gnu.org; Wed, 24 May 2006 17:10:15 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fj0gx-0003gU-HX for emacs-devel@gnu.org; Wed, 24 May 2006 17:14:55 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Fj0cB-0000Xs-5I for emacs-devel@gnu.org; Wed, 24 May 2006 23:09:59 +0200 Original-Received: from linus003.dd.chalmers.se ([129.16.117.203]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 May 2006 23:09:59 +0200 Original-Received: from bojohan+news by linus003.dd.chalmers.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 May 2006 23:09:59 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-To: emacs-devel@gnu.org Original-Lines: 26 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: linus003.dd.chalmers.se Mail-Copies-To: never User-Agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:TS0eihulM0p4Jv9MAZR9FUNxQpw= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55224 Archived-At: Kevin Rodgers writes: > David Kastrup wrote: >> Kevin Rodgers writes: >> >>> Kazu Yamamoto (山本和彦) wrote: >>>> If the CONFIRM argument is specified to read-passwd of CVS Emacs, it >>>> causes an error after a user type a first password. >>>> >>>> (read-passwd "password: " t) >>> The error is "Attempt to modify read-only object" and is somehow caused >>> by a string indexing bug. Here's a patch: > ... >> Looks like causing trouble when the prompt is an empty string. And >> it looks like it would leave the properties off the last character >> of the prompt. Correct? > > You're right on both counts -- thanks for catching that! I should > have investigated further before posting a patch that has nothing to > do with the underlying error. Your latest patch also has nothing to do with it AFAICT. The string is in pure storage--you need to make a copy. -- Johan Bockgård