unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Modernize the default list of archives supported by dired guesses
@ 2011-02-27 15:07 Antoine Levitt
  2011-02-28  3:33 ` Stefan Monnier
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Antoine Levitt @ 2011-02-27 15:07 UTC (permalink / raw)
  To: emacs-devel

Here's a trivial patch to add 7z and unrar (both free software) to the
list of guessed archivers. Can you merge it? 

Antoine

diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index ce07676..6ed3cd1 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
    '("\\.lzh$" "lharc x")
    '("\\.arc$" "arc x")
    '("\\.shar$" "unshar")
+   '("\\.rar$" "unrar x")
+   '("\\.7z$" "7z x")
 
    ;; Compression.
    (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))




^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-27 15:07 Modernize the default list of archives supported by dired guesses Antoine Levitt
@ 2011-02-28  3:33 ` Stefan Monnier
  2011-02-28  8:03   ` Glenn Morris
  2011-02-28  7:24 ` Glenn Morris
  2011-03-01 15:59 ` Jeff Sparkes
  2 siblings, 1 reply; 11+ messages in thread
From: Stefan Monnier @ 2011-02-28  3:33 UTC (permalink / raw)
  To: Antoine Levitt; +Cc: emacs-devel

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

That looks right, but please whoever installs this patch, replace the
dollars with \\' in this list of regexps.


        Stefan


> diff --git a/lisp/dired-x.el b/lisp/dired-x.el
> index ce07676..6ed3cd1 100644
> --- a/lisp/dired-x.el
> +++ b/lisp/dired-x.el
> @@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
>     '("\\.lzh$" "lharc x")
>     '("\\.arc$" "arc x")
>     '("\\.shar$" "unshar")
> +   '("\\.rar$" "unrar x")
> +   '("\\.7z$" "7z x")
 
>     ;; Compression.
>     (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))
        



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-27 15:07 Modernize the default list of archives supported by dired guesses Antoine Levitt
  2011-02-28  3:33 ` Stefan Monnier
@ 2011-02-28  7:24 ` Glenn Morris
  2011-02-28  7:34   ` Antoine Levitt
  2011-03-01 15:59 ` Jeff Sparkes
  2 siblings, 1 reply; 11+ messages in thread
From: Glenn Morris @ 2011-02-28  7:24 UTC (permalink / raw)
  To: Antoine Levitt; +Cc: emacs-devel

Antoine Levitt wrote:

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

No, but I did commit it. :)

You have a few small changes in Emacs now. If you expect to contribute
more, you might want to think about completing a copyright assignment.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-28  7:24 ` Glenn Morris
@ 2011-02-28  7:34   ` Antoine Levitt
  2011-02-28  7:39     ` Glenn Morris
  2011-03-01 18:20     ` Richard Stallman
  0 siblings, 2 replies; 11+ messages in thread
From: Antoine Levitt @ 2011-02-28  7:34 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

28/02/11 08:24, Glenn Morris
> Antoine Levitt wrote:
>
>> Here's a trivial patch to add 7z and unrar (both free software) to the
>> list of guessed archivers. Can you merge it? 
>
> No, but I did commit it. :)

Ah, it seems I'm not up to date on the terminology. You commit changes
and merge commits, right?

Well, thanks for the commit, then!

> You have a few small changes in Emacs now. If you expect to contribute
> more, you might want to think about completing a copyright assignment.

Yes, I've sent the papers back last week. I'm waiting to hear from the
FSF.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-28  7:34   ` Antoine Levitt
@ 2011-02-28  7:39     ` Glenn Morris
  2011-03-01 18:20     ` Richard Stallman
  1 sibling, 0 replies; 11+ messages in thread
From: Glenn Morris @ 2011-02-28  7:39 UTC (permalink / raw)
  To: Antoine Levitt; +Cc: emacs-devel

Antoine Levitt wrote:

>> No, but I did commit it. :)

Actually Savannah is being slow again, so the commit is still pending. I
might have to kill it actually, since I am not sure if it is making any
progress at all...

> Ah, it seems I'm not up to date on the terminology. You commit changes
> and merge commits, right?

It's me who's not up to date. I just commit things like I used to with CVS.
None of this pushing etc nonsense.

> Yes, I've sent the papers back last week. I'm waiting to hear from the
> FSF.

Great.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-28  3:33 ` Stefan Monnier
@ 2011-02-28  8:03   ` Glenn Morris
  2011-02-28 14:47     ` Stefan Monnier
  0 siblings, 1 reply; 11+ messages in thread
From: Glenn Morris @ 2011-02-28  8:03 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier wrote:

> That looks right, but please whoever installs this patch, replace the
> dollars with \\' in this list of regexps.

I would have done, but Savannah is so slow I gave up.
(Does dired even work with filenames with embedded newlines?)



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-28  8:03   ` Glenn Morris
@ 2011-02-28 14:47     ` Stefan Monnier
  0 siblings, 0 replies; 11+ messages in thread
From: Stefan Monnier @ 2011-02-28 14:47 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> (Does dired even work with filenames with embedded newlines?)

Last I checked, there is some code that would allow it, but more
is missing.  Still, no excuse to use $ when \' is meant (such changes
are largely motivated by trying to make sure users see good examples).


        Stefan



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-27 15:07 Modernize the default list of archives supported by dired guesses Antoine Levitt
  2011-02-28  3:33 ` Stefan Monnier
  2011-02-28  7:24 ` Glenn Morris
@ 2011-03-01 15:59 ` Jeff Sparkes
  2 siblings, 0 replies; 11+ messages in thread
From: Jeff Sparkes @ 2011-03-01 15:59 UTC (permalink / raw)
  To: emacs-devel

Antoine Levitt <antoine.levitt@gmail.com> writes:

> Here's a trivial patch to add 7z and unrar (both free software) to the
> list of guessed archivers. Can you merge it? 

On cygwin, it's "p7zip".  You could search for either 7z or p7zip.  Most
of the entries aren't validated though.  It's a shame it's not an alist.

>
> Antoine
>
> diff --git a/lisp/dired-x.el b/lisp/dired-x.el
> index ce07676..6ed3cd1 100644
> --- a/lisp/dired-x.el
> +++ b/lisp/dired-x.el
> @@ -988,6 +988,8 @@ replace it with a dir-locals-file `./%s'"
>     '("\\.lzh$" "lharc x")
>     '("\\.arc$" "arc x")
>     '("\\.shar$" "unshar")
> +   '("\\.rar$" "unrar x")
> +   '("\\.7z$" "7z x")fdired-x
>  
>     ;; Compression.
>     (list "\\.g?z$" '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-02-28  7:34   ` Antoine Levitt
  2011-02-28  7:39     ` Glenn Morris
@ 2011-03-01 18:20     ` Richard Stallman
  2011-03-01 18:29       ` Antoine Levitt
  1 sibling, 1 reply; 11+ messages in thread
From: Richard Stallman @ 2011-03-01 18:20 UTC (permalink / raw)
  To: Antoine Levitt; +Cc: emacs-devel

Last I checked, unrar is not free software.  We are looking for
someone to write a free program to do that.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-03-01 18:20     ` Richard Stallman
@ 2011-03-01 18:29       ` Antoine Levitt
  2011-03-02  9:45         ` Richard Stallman
  0 siblings, 1 reply; 11+ messages in thread
From: Antoine Levitt @ 2011-03-01 18:29 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

01/03/11 19:20, Richard Stallman
> Last I checked, unrar is not free software.  We are looking for
> someone to write a free program to do that.

Apparently, most distros package http://www.unrarlib.org/faq.html, which
is GPLv2, as "unrar", so there's no problem.

Ubuntu packages this as "unrar-free", and also has an "unrar" package
which is proprietary and supports RAR 3. Both provide /usr/bin/unrar.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Modernize the default list of archives supported by dired guesses
  2011-03-01 18:29       ` Antoine Levitt
@ 2011-03-02  9:45         ` Richard Stallman
  0 siblings, 0 replies; 11+ messages in thread
From: Richard Stallman @ 2011-03-02  9:45 UTC (permalink / raw)
  To: Antoine Levitt; +Cc: emacs-devel

    Apparently, most distros package http://www.unrarlib.org/faq.html, which
    is GPLv2, as "unrar", so there's no problem.

I see.  I think this supports RAR 2 and we don't have free software
for RAR 3.

So the free unrar is ok to support for whatever good it does.


-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2011-03-02  9:45 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-27 15:07 Modernize the default list of archives supported by dired guesses Antoine Levitt
2011-02-28  3:33 ` Stefan Monnier
2011-02-28  8:03   ` Glenn Morris
2011-02-28 14:47     ` Stefan Monnier
2011-02-28  7:24 ` Glenn Morris
2011-02-28  7:34   ` Antoine Levitt
2011-02-28  7:39     ` Glenn Morris
2011-03-01 18:20     ` Richard Stallman
2011-03-01 18:29       ` Antoine Levitt
2011-03-02  9:45         ` Richard Stallman
2011-03-01 15:59 ` Jeff Sparkes

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).