* Re: ange-ftp save-buffer bug in 21.2
[not found] <200207101818.g6AIIND19276@video.paradise.lost>
@ 2002-07-11 12:01 ` Richard Stallman
2002-07-12 7:01 ` Michael Sperber [Mr. Preprocessor]
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2002-07-11 12:01 UTC (permalink / raw)
Cc: emacs-devel
The problem is evidently because of the following code in
ange-ftp-write-region.
(let ((executing-kbd-macro t)
(filename (buffer-file-name))
(mod-p (buffer-modified-p)))
(unwind-protect
(progn
(ange-ftp-real-write-region start end temp nil visit)
(setq coding-system-used last-coding-system-used))
Does anyone see a purpose for binding executing-kbd-macro here? The
code to bind it has been that way for a long, long time.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: ange-ftp save-buffer bug in 21.2
2002-07-11 12:01 ` ange-ftp save-buffer bug in 21.2 Richard Stallman
@ 2002-07-12 7:01 ` Michael Sperber [Mr. Preprocessor]
2002-07-12 17:38 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Michael Sperber [Mr. Preprocessor] @ 2002-07-12 7:01 UTC (permalink / raw)
Cc: jdhunter, emacs-devel
>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:
RMS> The problem is evidently because of the following code in
RMS> ange-ftp-write-region.
RMS> (let ((executing-kbd-macro t)
RMS> (filename (buffer-file-name))
RMS> (mod-p (buffer-modified-p)))
RMS> (unwind-protect
RMS> (progn
RMS> (ange-ftp-real-write-region start end temp nil visit)
RMS> (setq coding-system-used last-coding-system-used))
RMS> Does anyone see a purpose for binding executing-kbd-macro here? The
RMS> code to bind it has been that way for a long, long time.
For what it's worth, here's the analogous section in EFS. It has a
comment:
(let ((executing-macro t))
;; let-bind executing-macro to inhibit messaging.
;; Setting VISIT to 'quiet is more elegant.
;; But in Emacs 18, doing it this way allows
;; us to modify the visited file modtime, so
;; that undo's show the buffer modified.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-07-12 17:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200207101818.g6AIIND19276@video.paradise.lost>
2002-07-11 12:01 ` ange-ftp save-buffer bug in 21.2 Richard Stallman
2002-07-12 7:01 ` Michael Sperber [Mr. Preprocessor]
2002-07-12 17:38 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).