unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: sperber@informatik.uni-tuebingen.de (Michael Sperber [Mr.  Preprocessor])
Cc: jdhunter@ace.bsd.uchicago.edu, emacs-devel@gnu.org
Subject: Re: ange-ftp save-buffer bug in 21.2
Date: Fri, 12 Jul 2002 09:01:47 +0200	[thread overview]
Message-ID: <y9lofdd77l0.fsf@sams.informatik.uni-tuebingen.de> (raw)
In-Reply-To: <200207111201.g6BC1Zc16964@aztec.santafe.edu> (Richard Stallman's message of "Thu, 11 Jul 2002 06:01:35 -0600 (MDT)")

>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:

RMS> The problem is evidently because of the following code in
RMS> ange-ftp-write-region.

RMS> 		(let ((executing-kbd-macro t)
RMS> 		      (filename (buffer-file-name))
RMS> 		      (mod-p (buffer-modified-p)))
RMS> 		  (unwind-protect
RMS> 		      (progn
RMS> 			(ange-ftp-real-write-region start end temp nil visit)
RMS> 			(setq coding-system-used last-coding-system-used))

RMS> Does anyone see a purpose for binding executing-kbd-macro here?  The
RMS> code to bind it has been that way for a long, long time.

For what it's worth, here's the analogous section in EFS.  It has a
comment:

			  (let ((executing-macro t))
			    ;; let-bind executing-macro to inhibit messaging.
			    ;; Setting VISIT to 'quiet is more elegant.
			    ;; But in Emacs 18, doing it this way allows
			    ;; us to modify the visited file modtime, so
			    ;; that undo's show the buffer modified.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla

  reply	other threads:[~2002-07-12  7:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200207101818.g6AIIND19276@video.paradise.lost>
2002-07-11 12:01 ` ange-ftp save-buffer bug in 21.2 Richard Stallman
2002-07-12  7:01   ` Michael Sperber [Mr.  Preprocessor] [this message]
2002-07-12 17:38     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y9lofdd77l0.fsf@sams.informatik.uni-tuebingen.de \
    --to=sperber@informatik.uni-tuebingen.de \
    --cc=emacs-devel@gnu.org \
    --cc=jdhunter@ace.bsd.uchicago.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).