From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Tue, 03 Dec 2019 14:20:44 -0500 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67115"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 03 21:11:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icEVk-000HLI-UF for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 21:11:05 +0100 Original-Received: from localhost ([::1]:58080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icEVi-0003V5-Nf for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 15:11:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45550) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icDjP-0008K1-1n for emacs-devel@gnu.org; Tue, 03 Dec 2019 14:21:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icDjM-0002oT-OQ for emacs-devel@gnu.org; Tue, 03 Dec 2019 14:21:06 -0500 Original-Received: from veto.sei.cmu.edu ([147.72.252.17]:49498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icDjL-0002VE-F5 for emacs-devel@gnu.org; Tue, 03 Dec 2019 14:21:04 -0500 Original-Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by veto.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id xB3JKmbW043123 for ; Tue, 3 Dec 2019 14:20:48 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 veto.sei.cmu.edu xB3JKmbW043123 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1575400848; bh=IupQF3JcGXHEV1TRCw3VXdUTwH3OHDHRk9JzlK+uN0E=; h=From:To:Subject:References:Date:In-Reply-To:From; b=IAKUZ2sNPqW+jhZUmjHWwy+M3Xmrp0qn7zxcfXeTVTylJZbfQWJUY6J5JG63lZfWw x5ubvtEaWIgx/RUQ9USJ8vz2MeGJ3ooseuN6rxQsv0vEJRJcZ8ZTOm/rxtdOUwx7b1 1pZX8ZHrgoVAenTgHem/OE16Y2BIGKPQt6466W9c= Original-Received: from lx-birch.ad.sei.cmu.edu (lx-birch.ad.sei.cmu.edu [10.64.53.120]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id xB3JKiCp004713 for ; Tue, 3 Dec 2019 14:20:44 -0500 Original-Received: from lx-birch.ad.sei.cmu.edu (localhost [127.0.0.1]) by lx-birch.ad.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id xB3JKiun013391 for ; Tue, 3 Dec 2019 14:20:44 -0500 Original-Received: (from mwd@localhost) by lx-birch.ad.sei.cmu.edu (8.14.7/8.14.7) id xB3JKi8q013388; Tue, 3 Dec 2019 14:20:44 -0500 X-Authentication-Warning: lx-birch.ad.sei.cmu.edu: mwd set sender to mwd@cert.org using -f In-Reply-To: (Stefan Monnier's message of "Tue, 03 Dec 2019 11:01:17 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 147.72.252.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243087 Archived-At: Stefan Monnier writes: >>> I'd rather fix the code not to rely on the return value. >> I'm sure a lot more code relies on the return value of 'push'. > > Probably, but I still think it's bad practice to use the return value of > an operation which is fundamentally a side-effect. But isn't that standard practice? From the elisp manual, for example: (setq x (nreverse x)) -- Michael Welsh Duggan (mwd@cert.org)