From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: PATCH: Fix IDO interaction with uniquify.el Date: Wed, 5 May 2010 11:56:50 +0200 Message-ID: References: <87k4vf1zdh.fsf@telefonica.net> <87d4171oy1.fsf@telefonica.net> <87636z1nm7.fsf@telefonica.net> <87d417h0z6.fsf@stupidchicken.com> <87tyujz57h.fsf@telefonica.net> <87ockrz4eu.fsf@telefonica.net> <87pr57uw25.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1273080773 32595 80.91.229.12 (5 May 2010 17:32:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 5 May 2010 17:32:53 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar_Fuentes?= , Chong Yidong , emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 05 19:32:51 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O9iSb-0004ed-3W for ged-emacs-devel@m.gmane.org; Wed, 05 May 2010 19:32:45 +0200 Original-Received: from localhost ([127.0.0.1]:47234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9iSW-00022y-Uw for ged-emacs-devel@m.gmane.org; Wed, 05 May 2010 13:32:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9bLw-0007kg-Ca for emacs-devel@gnu.org; Wed, 05 May 2010 05:57:16 -0400 Original-Received: from [140.186.70.92] (port=58134 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9bLt-0007jK-Ow for emacs-devel@gnu.org; Wed, 05 May 2010 05:57:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9bLs-0002Br-2S for emacs-devel@gnu.org; Wed, 05 May 2010 05:57:13 -0400 Original-Received: from mail-bw0-f225.google.com ([209.85.218.225]:49915) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9bLr-0002Bg-Ts for emacs-devel@gnu.org; Wed, 05 May 2010 05:57:12 -0400 Original-Received: by bwz25 with SMTP id 25so2866434bwz.8 for ; Wed, 05 May 2010 02:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=oqh+C+5snp2XWhzgDSdp8kkCb48QJJEW9NGgDSDWzdE=; b=hwjTf1fOnq8PnyVIVGuBHcnYRDIYjCQ/MpqF+gjM820h2MMQJckUKZUG7ZULdxQIXt n+LszTbiJVCdgd1yHC143SbGGiy0DQ9cpSWgNt9+ReHwsZ/uRgmj0i0zEJ8hPstH4A4/ W4C9aX1pMKU+6PPIkp/ZUSTA3TCuiYU6KbZx4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=iVM/T3InufI8oG4x40NZ1Nlp5kXdp9ySy0+ZVBcqLdfZo8vX5QP6mc7g8CvLneB/pL qaj5aCvP7+Hgql3jHiH4B5pH6W0K3P6s/gC0DNxmuDZPMlzNCvZ2kO3vmRd3hEupn1U8 7mnayJmTCKDoiKvhXxnsFfWEk16DpJ2TqEXqo= Original-Received: by 10.204.141.214 with SMTP id n22mr2466731bku.18.1273053430447; Wed, 05 May 2010 02:57:10 -0700 (PDT) Original-Received: by 10.204.84.81 with HTTP; Wed, 5 May 2010 02:56:50 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124539 Archived-At: On Wed, May 5, 2010 at 10:27, Leo wrote: > I confirm the original bug report. I propose here a different fix for > both ido and iswitch. It is much simpler and more efficient. On the minus side, your patch: - is less generic; =C3=93scar's will work for other packages that do dynamic renaming of buffers (yes, there are none on the Emacs distribution, but there's a lot of elisp code out there). - makes ido depend on a feature of uniquify, which it didn't before. > (buffer-list) can be a large list given the new feature virtual buffers > in both iswitch and ido modes. Has that been a problem for you? It should only be if you have a really long list of buffers *and* use ido-kill-buffer a lot on the same ido-switch-buffer invocation... IMHO the virtual buffers feature is still a bit unfinished. For example, it doesn't support multiple "virtual buffers" for files with the same name on different directories. There was talk of using uniquify to fix that, but again, my feeling is that tying ido to uniquify is unwise; the virtual buffers implementation (on ido) should fix its own problems in a more generic way. Just my 0,02=E2=82=AC Juanma