From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code Date: Fri, 24 Apr 2015 16:52:48 -0400 Message-ID: References: <20150424201140.20928.62979@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1429908820 32090 80.91.229.3 (24 Apr 2015 20:53:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Apr 2015 20:53:40 +0000 (UTC) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 24 22:53:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YlkbO-0001ua-0L for ged-emacs-devel@m.gmane.org; Fri, 24 Apr 2015 22:53:34 +0200 Original-Received: from localhost ([::1]:46485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlkbN-0002n7-5n for ged-emacs-devel@m.gmane.org; Fri, 24 Apr 2015 16:53:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ylkah-0000zP-Io for emacs-devel@gnu.org; Fri, 24 Apr 2015 16:52:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ylkaf-0004rC-M3 for emacs-devel@gnu.org; Fri, 24 Apr 2015 16:52:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ylkaf-0004qt-JI for emacs-devel@gnu.org; Fri, 24 Apr 2015 16:52:49 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Ylkae-0000MY-MR; Fri, 24 Apr 2015 16:52:48 -0400 X-Spook: jihad eternity server Juiliett Class Submarine Commecen X-Ran: u==reIXIhVn=TSD;ImZ[fNUHi{#AuHkU;{&5],\QS~f-6w88rHleB\FE[Ne!1|GzI3"_iA X-Hue: green X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Fri, 24 Apr 2015 20:11:40 +0000") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185859 Archived-At: Stefan Monnier wrote: > branch: master > commit e224c9465dfe7033b11c0aeb830298c101c9bdcc > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code So tight it doesn't build. :( > (declare (indent 1) (debug ((symbolp form &optional form) body))) > (let ((is-list (make-symbol "is-list")) > (seq (make-symbol "seq")) > (index (make-symbol "index"))) > `(let* ((,seq ,(cadr spec)) > - (,is-list (listp ,seq)) > + (,length (if (listp ,seq) nil (seq-length ,seq))) Missing make-symbol for "length"? > (,index (if ,is-list ,seq 0))) "is-list" no longer set but still referenced?