* Re: master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code
[not found] ` <E1Yljwq-0005SA-84@vcs.savannah.gnu.org>
@ 2015-04-24 20:52 ` Glenn Morris
2015-04-24 22:35 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2015-04-24 20:52 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier wrote:
> branch: master
> commit e224c9465dfe7033b11c0aeb830298c101c9bdcc
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code
So tight it doesn't build. :(
> (declare (indent 1) (debug ((symbolp form &optional form) body)))
> (let ((is-list (make-symbol "is-list"))
> (seq (make-symbol "seq"))
> (index (make-symbol "index")))
> `(let* ((,seq ,(cadr spec))
> - (,is-list (listp ,seq))
> + (,length (if (listp ,seq) nil (seq-length ,seq)))
Missing make-symbol for "length"?
> (,index (if ,is-list ,seq 0)))
"is-list" no longer set but still referenced?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code
2015-04-24 20:52 ` master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code Glenn Morris
@ 2015-04-24 22:35 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2015-04-24 22:35 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> So tight it doesn't build. :(
Dhu! I geus sI saw rdunk ro somtehing!
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-24 22:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150424201140.20928.62979@vcs.savannah.gnu.org>
[not found] ` <E1Yljwq-0005SA-84@vcs.savannah.gnu.org>
2015-04-24 20:52 ` master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code Glenn Morris
2015-04-24 22:35 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).