From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code
Date: Fri, 24 Apr 2015 16:52:48 -0400 [thread overview]
Message-ID: <xy8udhmeov.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <E1Yljwq-0005SA-84@vcs.savannah.gnu.org> (Stefan Monnier's message of "Fri, 24 Apr 2015 20:11:40 +0000")
Stefan Monnier wrote:
> branch: master
> commit e224c9465dfe7033b11c0aeb830298c101c9bdcc
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code
So tight it doesn't build. :(
> (declare (indent 1) (debug ((symbolp form &optional form) body)))
> (let ((is-list (make-symbol "is-list"))
> (seq (make-symbol "seq"))
> (index (make-symbol "index")))
> `(let* ((,seq ,(cadr spec))
> - (,is-list (listp ,seq))
> + (,length (if (listp ,seq) nil (seq-length ,seq)))
Missing make-symbol for "length"?
> (,index (if ,is-list ,seq 0)))
"is-list" no longer set but still referenced?
next parent reply other threads:[~2015-04-24 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150424201140.20928.62979@vcs.savannah.gnu.org>
[not found] ` <E1Yljwq-0005SA-84@vcs.savannah.gnu.org>
2015-04-24 20:52 ` Glenn Morris [this message]
2015-04-24 22:35 ` master e224c94: * lisp/emacs-lisp/seq.el (seq-doseq): Tighten the code Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xy8udhmeov.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).