From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: elisp-benchmarks Date: Fri, 06 Dec 2019 22:56:50 +0000 Message-ID: References: <87tv6dfe3c.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="79609"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (berkeley-unix) Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 06 23:57:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idMXN-000KXv-AR for ged-emacs-devel@m.gmane.org; Fri, 06 Dec 2019 23:57:25 +0100 Original-Received: from localhost ([::1]:46148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idMXL-0003Go-GC for ged-emacs-devel@m.gmane.org; Fri, 06 Dec 2019 17:57:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60841) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idMX7-0003Gc-6C for emacs-devel@gnu.org; Fri, 06 Dec 2019 17:57:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idMX4-00011z-UB for emacs-devel@gnu.org; Fri, 06 Dec 2019 17:57:08 -0500 Original-Received: from mx.sdf.org ([205.166.94.20]:57963) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1idMX4-0000va-Kf for emacs-devel@gnu.org; Fri, 06 Dec 2019 17:57:06 -0500 Original-Received: from sdf.org (IDENT:akrl@sdf.lonestar.org [205.166.94.16]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id xB6Muppe025119 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO); Fri, 6 Dec 2019 22:56:51 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id xB6MuooD020058; Fri, 6 Dec 2019 22:56:50 GMT In-Reply-To: <87tv6dfe3c.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 06 Dec 2019 11:28:39 -0800") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 205.166.94.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243202 Archived-At: Eric Abrahamsen writes: > Andrea Corallo writes: > >> Hi, I attach the patch git formatted. I've also fixed two nits. > > Thanks for this package, and I'm looking forward to trying it out! I > have one question at this point, which is that it seems somewhat > limiting to require benchmarks to be placed into this package's own > benchmarks/ directory. It seems like it would be nice to let them live > anywhere, even if that means selecting them manually, rather than > forcing a single location, as the package currently seems to do (unless > I'm missing something?). For example, it might be nice to ship other > packages with their own benchmark libraries, which would then be > selectable somehow. What do you think? > > Thanks! > Eric Hi Eric, that's a very good point thanks for commenting. Actually with the current setup you could depose a benchmark in the benchmarks folder that calls say some gnus function and define a test in that way. Everything would work except the 'recompile'. I also like the idea of doing the other way around (defining benchmarks and have them shipped with the package itself). This would be potentially more elegant but I guess we should then have the infrastructure to do that in Emacs and not just in ELPA. Is this correct? Maybe you have in mind a different mechanism for this? Bests Andrea -- akrl@sdf.org