From: Andrea Corallo <akrl@sdf.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: elisp-benchmarks
Date: Fri, 06 Dec 2019 22:56:50 +0000 [thread overview]
Message-ID: <xjfzhg5dpvx.fsf@sdf.org> (raw)
In-Reply-To: <87tv6dfe3c.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 06 Dec 2019 11:28:39 -0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Hi, I attach the patch git formatted. I've also fixed two nits.
>
> Thanks for this package, and I'm looking forward to trying it out! I
> have one question at this point, which is that it seems somewhat
> limiting to require benchmarks to be placed into this package's own
> benchmarks/ directory. It seems like it would be nice to let them live
> anywhere, even if that means selecting them manually, rather than
> forcing a single location, as the package currently seems to do (unless
> I'm missing something?). For example, it might be nice to ship other
> packages with their own benchmark libraries, which would then be
> selectable somehow. What do you think?
>
> Thanks!
> Eric
Hi Eric,
that's a very good point thanks for commenting.
Actually with the current setup you could depose a benchmark in the
benchmarks folder that calls say some gnus function and define a test in
that way. Everything would work except the 'recompile'.
I also like the idea of doing the other way around (defining benchmarks
and have them shipped with the package itself). This would be
potentially more elegant but I guess we should then have the
infrastructure to do that in Emacs and not just in ELPA. Is this
correct?
Maybe you have in mind a different mechanism for this?
Bests
Andrea
--
akrl@sdf.org
next prev parent reply other threads:[~2019-12-06 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 19:06 [ELPA] New package: elisp-benckmarks Andrea Corallo
2019-12-05 19:18 ` [ELPA] New package: elisp-benchmarks Andrea Corallo
2019-12-06 14:48 ` Andrea Corallo
2019-12-06 19:28 ` Eric Abrahamsen
2019-12-06 22:56 ` Andrea Corallo [this message]
2019-12-07 17:27 ` Eric Abrahamsen
2019-12-07 18:27 ` Stefan Monnier
2019-12-07 21:03 ` Eric Abrahamsen
2019-12-08 0:20 ` Stefan Monnier
2019-12-08 17:15 ` Eric Abrahamsen
2019-12-08 20:38 ` Andrea Corallo
2019-12-08 21:05 ` Eric Abrahamsen
2019-12-11 11:17 ` Andrea Corallo
2019-12-18 13:13 ` Andrea Corallo
2019-12-19 4:27 ` Stefan Monnier
2019-12-19 8:42 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfzhg5dpvx.fsf@sdf.org \
--to=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).