From: Andrea Corallo <akrl@sdf.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838)
Date: Tue, 19 May 2020 07:33:30 +0000 [thread overview]
Message-ID: <xjfzha44bw5.fsf@sdf.org> (raw)
In-Reply-To: <jwvlflo1u7s.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 18 May 2020 23:27:42 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> nothing against kittens but I'm not really sure we can put a function
>> there. Have you took a look on how it's used?
>
> Briefly, yes, and I didn't see a problem with inserting a (funcall <foo>)
> in place of inserting the form. What am I missing?
The case discussed in the PR is when some dynamically generated code (by
in this case straight.el) must me passed to the async workers to modify
the compiler environment.
`comp-async-env-modifier-form' is used with others to form the command
line that is the mechanism we use to setup and start the async workers.
`comp-async-env-modifier-form' must be then prin1-able and does not
necessarly refer to any function defined on file.
In case there's a more elegant way let's go for it.
Andrea
--
akrl@sdf.org
prev parent reply other threads:[~2020-05-19 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200518201401.22247.78014@vcs0.savannah.gnu.org>
[not found] ` <20200518201403.5855320BC2@vcs0.savannah.gnu.org>
2020-05-18 21:23 ` feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838) Stefan Monnier
2020-05-18 22:03 ` Andrea Corallo
2020-05-19 3:27 ` Stefan Monnier
2020-05-19 7:33 ` Andrea Corallo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfzha44bw5.fsf@sdf.org \
--to=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).