From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Merging native-comp and pgtk Date: Sun, 14 Feb 2021 18:36:56 +0000 Message-ID: References: <07D5E64D-DAD0-45B3-B272-627A73D7CBAE@gmail.com> <87mtwhctte.fsf@gnus.org> <459A0475-E3E7-4159-82DF-93809CCF1E24@gmail.com> <87eehng52n.fsf@gnus.org> <87mtwbye5b.fsf@gmail.com> <87czx7ycva.fsf@tcd.ie> <87eehmyalr.fsf@gmail.com> <877dneoewi.fsf@tcd.ie> <875z2yy6z7.fsf@gmail.com> <878s7twq2t.fsf@gmail.com> <84adc238-c424-bb6b-da28-c4232172da5b@gmx.at> <87wnvcrze8.fsf@gnus.org> <87eehkfbab.fsf@gnu.org> <878s7sqiww.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Tassilo Horn , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 14 20:15:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBMrG-0008tm-EA for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Feb 2021 20:15:02 +0100 Original-Received: from localhost ([::1]:34616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBMrF-0005s5-GN for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Feb 2021 14:15:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBMGT-0005Nv-PW for emacs-devel@gnu.org; Sun, 14 Feb 2021 13:37:02 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:63365) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBMGQ-0002jd-Lz; Sun, 14 Feb 2021 13:37:01 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11EIauB8022855 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 14 Feb 2021 18:36:56 GMT In-Reply-To: (Stefan Kangas's message of "Sat, 13 Feb 2021 09:38:38 -0800") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264763 Archived-At: Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> I've got one question about how things are compiled that I meant to ask >> but forgot: Why is AOT not the default, and why does the native-comp >> branch do compilation on-the-fly in the background? > > For me, it is a happy middle-ground: I do not need to make > NATIVE_FULL_AOT=1 (which is slower) but can still rely on getting the > performance increase automagically. > > Lars Ingebrigtsen writes: > >> Tassilo Horn writes: >> >>> Given that the ELN compilation takes quite some time, I think that's one >>> major reason. Another thing is that the on-the-fly compilation also >>> compiles all ELPA packages and even packages just residing somewhere on >>> my customized load-path which aren't accessible at emacs build time. >> >> That's nice, but it's unusual for Emacs to do something like that. >> >> When installing an ELPA package, Emacs byte-compiles the files, right? >> So it should do .eln compilation at the same time, in my opinion. > > It would have some benefits I guess, but it would slow down package > installation. Whatever we do, it would be nice to avoid that. > > On the nativecomp branch, package.el requests to do the .eln compilation > asynchronously in the background. AFAIU, if Emacs is killed before the > package is compiled, it will be put back in the compilation queue after > the package is used in a subsequent session. > > The drawback is that we get compilation warnings pop up every now and > then, which is arguably somewhat disruptive. But this could be improved > upon, I think. For example, I'm not sure users need to see all warnings > by default for installed packages even in the byte-compilation case. We > could perhaps have an option to enable these warnings for the genuine > sticklers out there. (I for one would definitely turn it on...) Hi Stefan, we have the `comp-async-report-warnings-errors' customize to control this. Andrea