unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: Robert Pluim <rpluim@gmail.com>, emacs-devel@gnu.org
Subject: Re: feature/native-comp c36b4ee 2/2: [TODO] Remove noisy anti-noise feature
Date: Wed, 18 Nov 2020 17:37:19 +0000	[thread overview]
Message-ID: <xjfy2iybm7k.fsf@sdf.org> (raw)
In-Reply-To: <87pn4abng6.fsf@bernoul.li> (Jonas Bernoulli's message of "Wed, 18 Nov 2020 18:10:33 +0100")

Jonas Bernoulli <jonas@bernoul.li> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> jonas@bernoul.li (Jonas Bernoulli) writes:
>>
>>> branch: feature/native-comp
>>> commit c36b4eed2d76f0e804d27d35dd6281f858639f94
>>> Author: Jonas Bernoulli <jonas@bernoul.li>
>>> Commit: Jonas Bernoulli <jonas@bernoul.li>
>>>
>>>     [TODO] Remove noisy anti-noise feature
>>> ---
>>>  lisp/emacs-lisp/warnings.el | 11 -----------
>>>  1 file changed, 11 deletions(-)
>>>
>>
>> Everyone is allowed to have an opinion on this feature, but just
>> removing it without discussion seems a little harsh.
>>
>> Robert
>
> That was an accidental push.  I do think it would be best to remove
> this new feature completely, but of course I would have raised the
> issue before *intentionally* removing it.

Hi Jonas,

thanks for the revert, please next time specify the reason of the revert
in the commit, (as I've recently discovered) this is the conventional
way to proceed :)

Ciao

  Andrea



      parent reply	other threads:[~2020-11-18 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201118142127.27797.43745@vcs0.savannah.gnu.org>
     [not found] ` <20201118142128.ABB2420521@vcs0.savannah.gnu.org>
2020-11-18 14:41   ` feature/native-comp 007a5a6 1/2: [WIP] Add and improve section headings Stefan Kangas
2020-11-18 16:11     ` Andrea Corallo via Emacs development discussions.
     [not found] ` <20201118142128.E137D20D1E@vcs0.savannah.gnu.org>
2020-11-18 15:17   ` feature/native-comp c36b4ee 2/2: [TODO] Remove noisy anti-noise feature Robert Pluim
2020-11-18 17:10     ` Jonas Bernoulli
2020-11-18 17:34       ` Silencing warnings with a button (was: feature/native-comp c36b4ee 2/2: [TODO] Remove noisy anti-noise feature) Stefan Monnier
2020-11-18 17:37       ` Andrea Corallo via Emacs development discussions. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfy2iybm7k.fsf@sdf.org \
    --to=emacs-devel@gnu.org \
    --cc=akrl@sdf.org \
    --cc=jonas@bernoul.li \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).