From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 20 Feb 2023 20:29:28 +0000 Message-ID: References: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> <837cwcwnpf.fsf@gnu.org> <834jrguvfd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24661"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, tats@debian.org, emacs-devel@gnu.org, spwhitton@spwhitton.name, 1021842@bugs.debian.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 20 21:30:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUCnq-0006CR-CD for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Feb 2023 21:30:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUCn1-00012u-CR; Mon, 20 Feb 2023 15:29:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUCn0-00012g-4e for emacs-devel@gnu.org; Mon, 20 Feb 2023 15:29:34 -0500 Original-Received: from ma.sdf.org ([205.166.94.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUCmy-0007qa-K1; Mon, 20 Feb 2023 15:29:33 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1pUCmu-0005pY-4N; Mon, 20 Feb 2023 20:29:28 +0000 In-Reply-To: <834jrguvfd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Feb 2023 18:57:10 +0200") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303622 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: monnier@iro.umontreal.ca, tats@debian.org, emacs-devel@gnu.org, >> spwhitton@spwhitton.name, 1021842@bugs.debian.org >> Date: Mon, 20 Feb 2023 15:42:08 +0000 >> >> > You mean, from master to emacs-29, I guess? >> >> Yes >> >> > What was the motivation for that change? The log message doesn't >> > explain the problem it meant to solve in enough detail, it just says >> > something about creating the file twice? How can that happen? who >> > creates the file the second time? >> >> Before e6043641d30 the file was created by Fmake_temp_file_internal and >> afterwards overwritten by libgccjit. So I guess one could remove the >> file after the first creation and make it a link pointing to some other >> file waiting for libgccjit to do its write. > > Then it's okay to cherry-pick it to emacs-29. (I actually am not sure > why we didn't install it on emacs-29 to begin with, but never mind.) I didn't install it at the time in emacs-29 as I thought this had nothing to do with security. Anyway this turned out not to be the best solution, so after today's discussion in this thread I've installed 5d0b45cd67b into emacs-29 as should be the optimal fix. Note there will be conflict in mergin 29 into 30 and we'll have to accept the change in 29 (sorry never managed to get gitmerge.el working here). Best Regards Andrea