From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: native-comp *Warnings* buffer Date: Sun, 16 May 2021 20:04:13 +0000 Message-ID: References: <87k0o2z9pr.fsf@ericabrahamsen.net> <83y2chzvxw.fsf@gnu.org> <87czttxquo.fsf@ericabrahamsen.net> <87y2cfwbz5.fsf@ericabrahamsen.net> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3928"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Richard Stallman , Stefan Monnier , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 22:11:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liN6T-0000pd-T6 for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 22:11:09 +0200 Original-Received: from localhost ([::1]:41312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liN6S-0007C3-SW for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 16:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liN07-0005ax-4j for emacs-devel@gnu.org; Sun, 16 May 2021 16:04:35 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liMzw-0002yY-UX; Sun, 16 May 2021 16:04:34 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14GK4Dv5013393 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 16 May 2021 20:04:13 GMT In-Reply-To: <87y2cfwbz5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 15 May 2021 21:15:26 -0700") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269374 Archived-At: Eric Abrahamsen writes: > Richard Stallman writes: > >> [[[ To any NSA and FBI agents reading my email: please consider ]]] >> [[[ whether defending the US Constitution against all enemies, ]]] >> [[[ foreign or domestic, requires you to follow Snowden's example. ]]] >> >> > I think "stealth" compilation performed opportunistically in the >> > background should indeed not display any warnings (by default). >> >> I understand the reason for saying that, but... would this mean that a >> compilation of that meaterial won't happen later? Is there a chance >> that you'll never see the warnings that compilation generates? > > This wouldn't affect the actual compilation at all. It could affect > whether the user sees the warnings or not, if we default to not popping > up the *Warnings* buffer. They might still go looking for the buffer, or > stumble upon it by accident, though. > > I've attached a patch that provides a 'silent option to > `native-comp-async-report-warnings-errors'. In this patch the default is > still t, though we could easily default to 'silent if that seems > desirable. Hi Eric, thanks for the patch, it sounds like a good idea. Just a small nit below otherwise LGTM. >>>From 01516b21e71862f3496e3a1f75bb86d436afaa3b Mon Sep 17 00:00:00 2001 > From: Eric Abrahamsen > Date: Sat, 15 May 2021 09:36:05 -0700 > Subject: [PATCH] Provide a 'silent option for > native-comp-asyncreport-warnings-errors > > * lisp/emacs-lisp/comp.el (native-comp-async-report-warnings-errors): > Set to 'silent to log warnings, but not pop up the *Warnings* buffer. > * lisp/emacs-lisp/comp.el (comp-accept-and-process-async-output): > Check value. > --- > lisp/emacs-lisp/comp.el | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-) > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 3e7f17ef1c..8fa9dee1ed 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -148,8 +148,13 @@ native-comp-async-report-warnings-errors > environment, it is more sensitive to such omissions, and might be > unable to compile such Lisp source files correctly. > > -Set this variable to nil if these warnings annoy you." > - :type 'boolean > +Set this variable to nil to suppress warnings altogether, or to > +the symbol `quiet' to log warnings but not pop up the *Warnings* ^^^ `silent'? > +buffer." > + :type '(choice > + (const :tag "Do not report warnings" nil) > + (const :tag "Report and display warnings" t) > + (const :tag "Report but do not display warnings" 'silent)) > :version "28.1") [...] Thanks Andrea