From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: master 9076a63 1/3: Port to Solaris 10 Date: Mon, 04 Jan 2021 16:08:13 +0000 Message-ID: References: <20210101205823.1572.21242@vcs0.savannah.gnu.org> <20210101205825.93701209C6@vcs0.savannah.gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 04 17:09:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwSQU-0003zH-HG for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 17:09:46 +0100 Original-Received: from localhost ([::1]:41270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwSQT-0000U7-Iw for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 11:09:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSPD-0007fe-Qb for emacs-devel@gnu.org; Mon, 04 Jan 2021 11:08:27 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:61693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSPB-0000SI-6A for emacs-devel@gnu.org; Mon, 04 Jan 2021 11:08:27 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 104G8Dal011444; Mon, 4 Jan 2021 16:08:13 GMT In-Reply-To: <20210101205825.93701209C6@vcs0.savannah.gnu.org> (Paul Eggert's message of "Fri, 1 Jan 2021 15:58:25 -0500 (EST)") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262438 Archived-At: eggert@cs.ucla.edu (Paul Eggert) writes: > branch: master > commit 9076a631fe331763414a5d323496846d563ccaa0 > Author: Paul Eggert > Commit: Paul Eggert > > Port to Solaris 10 >=20=20=20=20=20 > * configure.ac: Instead of AC_CHECK_HEADER, use AC_COMPILE_IFELSE > with X11/Intrinsic.h when checking for X11/extensions/Xrender.h. > This suppresses a bogus "report a bug to bug-gnu-emacs" diagnostic > from 'configure' in Solaris 10. > (SETUP_SLAVE_PTY): Adjust to recent renaming of forkin to > std_in in callproc.c. Needed on Solaris and Unixware. > * lib-src/Makefile.in (LIB_GETRANDOM, LIBS_ETAGS): New vars, > needed because on Solaris 10 the Gnulib tempname module now needs > the -lrt library for clock_gettime. Throw in the LIB_GETRANDOM > stuff too while we=E2=80=99re at it; from getrandom.m4 it seems to be > needed for MingW. > (LIBS_MOVE, etags_libs): Use them. > * src/callproc.c [SETUP_SLAVE_PTY]: Include sys/stream.h > and sys/stropts.h, for SETUP_SLAVE_PTY=E2=80=99s definiens. > * src/process.c [NEED_BSDTTY]: Don=E2=80=99t include bsdtty.h; hasn= =E2=80=99t been > needed in years. > [USG5_4]: Don=E2=80=99t include sys/stream.h or sys/stropts.h; these > directives havbe been moved to callproc.c because the only use of > SETUP_SLAVE_PTY is there now. > --- > configure.ac | 9 +++++++-- > lib-src/Makefile.in | 9 +++++++-- > src/callproc.c | 5 +++++ > src/process.c | 9 --------- > 4 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 574024a..5f822fe 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3291,7 +3291,12 @@ fi > # Check for XRender > HAVE_XRENDER=3Dno > if test "${HAVE_X11}" =3D "yes"; then > - AC_CHECK_HEADER([X11/extensions/Xrender.h], > + AC_COMPILE_IFELSE( > + [AC_LANG_PROGRAM( > + [[#include > + #include > + ]], > + [[return !XRenderQueryExtension;]])], > [AC_CHECK_LIB([Xrender], [XRenderQueryExtension], [HAVE_XRENDER=3Dye= s])]) > if test $HAVE_XRENDER =3D yes; then > XRENDER_LIBS=3D"-lXrender" > @@ -4926,7 +4931,7 @@ case $opsys in Master does not build for me on Ubuntu 18.04.3, I think is because of the above hunk. This is the error: =3D=3D=3D=3D=3D=3D=3D=3D CCLD temacs /usr/bin/ld: xterm.o: undefined reference to symbol 'XRenderQueryExtension' //usr/lib/x86_64-linux-gnu/libXrender.so.1: error adding symbols: DSO missi= ng from command line collect2: error: ld returned 1 exit status Makefile:655: recipe for target 'temacs' failed =3D=3D=3D=3D=3D=3D=3D=3D We don't add -lXrender. I do have "X11/extensions/Xrender.h" but not "X11/Intrinsic.h". Andrea