From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Compressed *.el files Date: Wed, 22 Sep 2021 16:02:01 +0000 Message-ID: References: <83ee9gwye0.fsf@gnu.org> <838rzowqr4.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5294"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 18:11:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT4qa-0001BQ-OJ for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 18:11:48 +0200 Original-Received: from localhost ([::1]:56222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT4qZ-0007O3-B4 for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 12:11:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4hG-0005Il-Rp for emacs-devel@gnu.org; Wed, 22 Sep 2021 12:02:11 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:52428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4hB-0002Y7-6I; Wed, 22 Sep 2021 12:02:10 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 18MG21gU012146 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 22 Sep 2021 16:02:02 GMT In-Reply-To: <838rzowqr4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Sep 2021 18:53:51 +0300") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275321 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: emacs-devel@gnu.org >> Date: Wed, 22 Sep 2021 15:19:40 +0000 >> >> > The function comp-el-to-eln-rel-filename is capable of processing >> > compressed *.el.gz files, which is of course needed for working >> > correctly in an installed Emacs. However, when it sees a file whose >> > name ends in .gz, it invokes the function md5_gz_stream, which is only >> > defined if Emacs was built with zlib. Does this have some fallback >> > (which I'm missing ATM) for when Emacs was built without zlib, or do >> > we need to add something there? >> >> Hi Eli, >> >> good point, I guess we should require zlib for >> --with-native-compilation. Is this problematic? > > I don't know if it's problematic. A build without zlib still could > use native-compilation, they should just disable compression of the > *.el files at "make install" time. So requiring zlib could be too > drastic. I see > I will make the changes to fail native compilation if the *.el files > are compressed, but zlib isn't available, and will write up something > regarding the installation in that case. Thanks Andrea