From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [External] : emacs-28 windows binaries available from alpha Date: Fri, 11 Feb 2022 09:16:25 +0000 Message-ID: References: <834k5d3hbv.fsf@gnu.org> <83o83l1v51.fsf@gnu.org> <83k0e3vox9.fsf@gnu.org> <83fsoruv2u.fsf@gnu.org> <83o83eudgz.fsf@gnu.org> <83ee4atzh5.fsf@gnu.org> <83v8xlst5p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18039"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 11 10:18:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIS43-0004P4-DB for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Feb 2022 10:18:03 +0100 Original-Received: from localhost ([::1]:39344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIS41-0000Ks-PG for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Feb 2022 04:18:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIS2p-00083A-T1 for emacs-devel@gnu.org; Fri, 11 Feb 2022 04:16:49 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:57260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIS2n-00032z-O4; Fri, 11 Feb 2022 04:16:47 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 21B9GPQ7021989 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 11 Feb 2022 09:16:25 GMT In-Reply-To: <83v8xlst5p.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Feb 2022 10:29:22 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286160 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org >> Date: Thu, 10 Feb 2022 18:34:22 +0000 >> >> Eli Zaretskii writes: >> >> >> PS I tried to merge emacs-28 into master using gitmerge.el as suggested >> >> in git-workflow as I suspected a conflict there that I wanted to solve >> >> myself, but it says "nothing to merge". Not sure if I'm doing something >> >> wrong. >> > >> > I merged that change, but for the future: what exactly did you do, and >> > in particular did you remember to switch to the master branch and do a >> > "git pull" in master, before invoking "gitmerge"? >> >> I did what's described in git-workflow, so yes I had master checked out >> and I pulled before trying. The only difference is that haven't started >> a fresh emacs but loaded gitmerge.el in my current session. Next time >> I'll try with a fresh session and maybe with -Q. > > What was the default-directory when you invoked "M-x gitmerge"? It > should be the Emacs repository, and Emacs should know that the current > branch in that directory is "master". Okay thanks next time I'll verify that as well. > Starting a new Emacs session is indeed better. (I also have separate > directories for master and the release branch, so for me changing the > default-directory ("M-x cd") also means I'm sure gitmerge will use the > correct branch.) > >> Anyway I was thinking if it wouldn't be correct to emit also a warning >> if libgccjit is not available. This condition could prevent some >> package to work as expected (ex evil-mode IIRC) so might be worth to >> inform the user that and emacs compiled with native-comp is being run >> without libgccjit being available. > > I'm not sure I see the usefulness of such a warning. If Emacs works > correctly regardless, the warning could annoy. So I tend to think we > should introduce the warning only if enough users complain that Emacs > silently does something they'd prefer to know about. I think it might be useful for two reasons: 1- let the user know that a native compiled Emacs is being run without access to libgccjit, not only it might not function as expected but most likely I guess that if the user compiled a native compiled Emacs he wants to have it working with native code. So in general I guess it might be informative. 2- help us identifying the issue when a bug is opened because of it, if we suspect that's the problem we can ask the user to have a look to the warnings. But indeed I'm not sure it's worth of so I asked. An alternative to point two would be having a trace of this in M-x report-emacs-bug. Another alternative to the problem on MS-Windows would be not to optimize calls to primitive functions and have them go always through funcall. This is very easy compiler wise but has probably too drastic as brings a performance penalty. Best Regards Andrea