From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30. Date: Tue, 01 Feb 2022 17:47:21 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2604"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 01 23:23:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF1Y0-000AJf-D9 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 23:22:48 +0100 Original-Received: from localhost ([::1]:52532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF1Xz-0006sd-A1 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 17:22:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nExFV-000787-Fz for emacs-devel@gnu.org; Tue, 01 Feb 2022 12:47:26 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:59811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nExFT-0003Z6-G9 for emacs-devel@gnu.org; Tue, 01 Feb 2022 12:47:25 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 211HlLcQ015312 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 1 Feb 2022 17:47:21 GMT In-Reply-To: (Alan Mackenzie's message of "Tue, 1 Feb 2022 17:17:56 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285742 Archived-At: Alan Mackenzie writes: > Hello, Andrea. > > In that patch, I made the following change so that a comparison > involving Qnil would not go through the (newly) expensive emit_EQ: > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 0a10505257..8581fe8066 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -1829,9 +1829,7 @@ comp-limplify-lap-inst > (byte-listp auto) > (byte-eq auto) > (byte-memq auto) > - (byte-not > - (comp-emit-set-call (comp-call 'eq (comp-slot-n (comp-sp)) > - (make-comp-mvar :constant nil)))) > + (byte-not null) > (byte-car auto) > (byte-cdr auto) > (byte-cons auto) > > .. Since then, there has been a mismatch in > test/lisp/emacs-lisp/comp-tests.log, comp-tests-ret-type-spec-55, where > the returned ret-type has now become t, whereas previously it was (not > integer). > > I don't really understand what ret-type is. The mismatch between what > this ret-type "should" be, and what it now is doesn't seem to be causing > any problems. Would you please say whether this is, in fact, true. > Would you also please advise on the best way to fix this bug in make > check. Hi Alan, ret-type is the return type of the function that the forward propagation engine tries to compute. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D (defun foo (x) (unless (integerp x) x)) (native-compile #'foo) (subr-type (symbol-function #'foo)) =3D> (function (t) (not integer)) ;; OR (subr-type (native-compile '(=CE=BB (x) (unless (integerp x) x)))) =3D> (function (t) (not integer)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Those two are probably now returning just: (function (t) t) I guess the fix should be around `comp-add-cond-cstrs' or `comp-add-cond-cstrs-simple'. I'll try to have a look later or tomorrow (unless you are so curious you like to take the task ;) Thanks! Andrea