From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] [WIP] Port feature/native-comp to Windows. Date: Wed, 13 May 2020 15:17:30 +0000 Message-ID: References: <5eb5b953.1c69fb81.a67ce.a764@mx.google.com> <83lfm1hc91.fsf@gnu.org> <83wo5lds87.fsf@gnu.org> <83lflzd8es.fsf@gnu.org> <83ftc7d4zu.fsf@gnu.org> <83blmvd2if.fsf@gnu.org> <833686d08r.fsf@gnu.org> <83eerp852g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="72256"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 13 17:18:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYt9T-000Ih7-89 for ged-emacs-devel@m.gmane-mx.org; Wed, 13 May 2020 17:18:31 +0200 Original-Received: from localhost ([::1]:44054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYt9S-0007iv-8A for ged-emacs-devel@m.gmane-mx.org; Wed, 13 May 2020 11:18:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYt8b-0005VF-GZ for emacs-devel@gnu.org; Wed, 13 May 2020 11:17:37 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:61007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYt8Z-0006gc-Pw; Wed, 13 May 2020 11:17:37 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04DFHUiX014515 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 13 May 2020 15:17:31 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04DFHUbL009656; Wed, 13 May 2020 15:17:30 GMT In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Wed, 13 May 2020 12:00:45 -0300") Received-SPF: pass client-ip=205.166.94.20; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 10:31:53 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250139 Archived-At: Nicolas B=C3=A9rtolo writes: >> Is there some specific reason for this choice? > > The problem is that w32_delayed_load will return a NULL handle if > Fassq (library_id, Vlibrary_cache)) returns non-nil. The only way to make= this > work is to avoid adding gccjit to Vlibrary_cache if the initialization fa= iled. > This would be different from what the code for loading other libraries do= es. > I don't know if it is worth it to introduce this difference. > > Another issue is that this code is called from maybe_defer_native_compila= tion(). > A version that searches for libgccjit all the time would call LoadLibrary= () and > perform an expensive search throughout the filesystem everytime `defalias= ` is > called. Uh I see! Yes then I think this solution is okay if the behavior is acceptable to win users. Otherwise would be necessary a new way for maybe_defer_native_compilation to check only for the last known state without triggering a new search. >>> PS: Shall I open a bug where we can track this? >> If affect all Emacs I think is the right thing to do. > > I referred to opening a bug report for the work related to porting > feature/native-comp to Windows. I think is a good idea, Eli will suggest. Thanks Andrea --=20 akrl@sdf.org