From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 05d240997a 2/2: Add native-compile-prune-cache command Date: Fri, 22 Jul 2022 16:50:24 +0000 Message-ID: References: <165675959499.8421.12451308740112322312@vcs2.savannah.gnu.org> <20220702105957.4B7EFC016B5@vcs2.savannah.gnu.org> <87bkthedix.fsf@gmail.com> <877d45b8sz.fsf@gmail.com> <8735etb5e1.fsf@gmail.com> <87y1wl9n2n.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13677"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Lars Ingebrigtsen To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 22 18:51:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEvsE-0003HM-3R for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jul 2022 18:51:34 +0200 Original-Received: from localhost ([::1]:52326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEvsC-0000LV-CW for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jul 2022 12:51:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEvrC-0007yf-LR for emacs-devel@gnu.org; Fri, 22 Jul 2022 12:50:30 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:59980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEvrA-0003RM-JY for emacs-devel@gnu.org; Fri, 22 Jul 2022 12:50:30 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 26MGoOmJ009793 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 22 Jul 2022 16:50:24 GMT In-Reply-To: <87y1wl9n2n.fsf@gmail.com> (Robert Pluim's message of "Fri, 22 Jul 2022 17:36:16 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292465 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Robert Pluim writes: >>>>>> On Fri, 22 Jul 2022 15:14:21 +0000, Andrea Corallo sa= id: > > Andrea> Robert Pluim writes: > >>>>>>> On Fri, 22 Jul 2022 13:51:04 +0000, Andrea Corallo said: > >> >> Right. The question is if we want to support such a case (and i= f so, > >> >> exactly how). > >>=20 > Andrea> Yep, I really thought the answer was no, at least for now, bu= t I might > Andrea> be wrong. > >>=20 > Andrea> BTW assuming the answer is no, should we add a load time chec= k with > Andrea> associated error or warning for comp.el to gate all these pos= sible > Andrea> issues? > >>=20 > >> I=CA=BCd lean towards a warning myself (both for loading and for r= unning > >> any of the commands inside comp.el) > > Andrea> FWIW I'd probably go just for the load-time warning. I fear = gating > Andrea> every function would probably bloat the code for not getting = much back. > > Something like this (untested) in `normal-top-level'? > > (unless (featurep 'native-compile) > (with-eval-after-load 'comp > (display-warning 'comp "This emacs does not support native compil= ation" :warning))) Yes something similar, wouldn't the attached be simpler? BR Andrea --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Warning-the-user-if-loading-comp-on-a-non-native-cap.patch >From 81bfe715e2137f0572bb17a51bdac3e4f8cd106d Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Fri, 22 Jul 2022 18:46:33 +0200 Subject: [PATCH] * Warning the user if loading comp on a non native capable Emacs. * lisp/emacs-lisp/comp.el: Warning the user if loading on a non native capable Emacs. --- lisp/emacs-lisp/comp.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 9a635a4776..b9de0289ee 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -28,6 +28,10 @@ ;;; Code: +(unless (featurep 'native-compile) + (display-warning 'comp "This emacs does not support native compilation" + :warning)) + (require 'bytecomp) (require 'cl-extra) (require 'cl-lib) -- 2.25.1 --=-=-=--